Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321261 - Run Last Launched External Tool opens External Tools Configurations window
Summary: Run Last Launched External Tool opens External Tools Configurations window
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M1   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-29 14:49 EDT by tehsven CLA
Modified: 2011-05-06 18:58 EDT (History)
3 users (show)

See Also:
pawel.1.piech: review+

Attachments
patch (1001 bytes, patch)
2010-07-30 09:20 EDT, Darin Wright CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tehsven CLA 2010-07-29 14:49:12 EDT 
Build Identifier: I20100608-0911

Executing the "Run Last Launched External Tool" action via a key binding does not execute the last launched external tool, but rather opens the "External Tools Configurations" window.

Reproducible: Always

Steps to Reproduce:
1. Bind a key to the "Run Last Launched External Tool" command.
2. Create an external tool configuration and launch it so it gets in the external tool launch history.
3. Press the key binding from step 1.

Expected result: The last launched external tool executes.
Actual result: The External Tools Configuration window pops up.
Comment 1 Prakash Rangaraj CLA 2010-07-29 23:53:24 EDT 
Moving to Platform Debug
Comment 2 Darin Wright CLA 2010-07-30 08:56:34 EDT 
I can reproduce the problem - but there is an issue with key binding selection here.

Since "CTRL-clicking" the toolbar actions (run, debug, external tools) opens the LCD on the assocaited launch configuration (last or associated with the selected resource), when a key binding with CTRL is chosen for the action the dialog is opened (since the code looks for the CTRL modifier). If a key binding is chosen without CTRL (like Shift-R, Shift-T), then it works.
Comment 3 Darin Wright CLA 2010-07-30 09:20:06 EDT 
Created attachment 175573 [details]
patch

This patch only looks at the CTRL modifier if the action was *not* invoked from the keyboard.
Comment 4 Darin Wright CLA 2010-07-30 09:20:51 EDT 
Fixed. Please review, Mike.
Comment 5 Pawel Piech CLA 2011-05-06 18:58:51 EDT 
Verified through testing.