Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321213 - [Theming] Only deliver current theme
Summary: [Theming] Only deliver current theme
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 1.5 M4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 338647 342047
  Show dependency tree
 
Reported: 2010-07-29 07:04 EDT by Benjamin Muskalla CLA
Modified: 2011-11-23 17:59 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2010-07-29 07:04:21 EDT
We currently deliver all registered themes to the client which takes up 142k javascript code. In the case for the Examples demo, we only need the business theme which has only 44k. I think this is worth to investigate when looking at client-side performance.
Comment 1 Tim Buschtoens CLA 2010-11-19 08:11:57 EST
Also on the topic of optimizing ThemeStore performance: Its worth looking into the "resolve" funtions called when the theme-values are define on the client. Afair they need a considerable amount of time at startup. Perhaps some of the stuff they are doing could be done on the server, or can be done on-demand by the ThemeStore.
Comment 2 Ralf Sternberg CLA 2011-11-23 17:59:11 EST
Themes are now registered as static JavaScript resources. Later on, we could even consider to let them contain only JSON.
Only the default and the current themes are included in the startup page now.
The default theme is still needed as a fallback, but this may change (see bug 363736).