Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321090 - [Dawn] Do not Require-Bundle plug-ins that are not provided by Eclipse.org
Summary: [Dawn] Do not Require-Bundle plug-ins that are not provided by Eclipse.org
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.dawn (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Martin Fluegge CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-28 02:39 EDT by Eike Stepper CLA
Modified: 2011-06-23 03:40 EDT (History)
0 users

See Also:
stepper: review+

Attachments
Patch v1 (2.00 KB, patch)
2010-07-30 09:56 EDT, Martin Fluegge CLA 		no flags Details | Diff
Patch v2 (2.17 KB, patch)
2010-08-06 11:32 EDT, Martin Fluegge CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Stepper CLA 2010-07-28 02:39:09 EDT 
We should depend on external components through Import-Package headers to enable users/deployers to choose different implementations.

I've found this in the org.eclipse.emf.cdo.dawn.codegen manifest:

Require-Bundle: com.ibm.icu;bundle-version="[4.0.0,5.0.0)",
 org.apache.commons.logging;bundle-version="[1.1.0,2.0.0)",
 org.apache.commons.lang;bundle-version="[2.3.0,3.0.0)",
 org.antlr.runtime;bundle-version="[3.0.0,4.0.0)",
Comment 1 Martin Fluegge CLA 2010-07-30 09:56:23 EDT 
Created attachment 175577 [details]
Patch v1

Ah. I see. Thanks for pointing me to this :)

I also had to add org.eclipse.emf.mwe2.runtime to the resolve its log4j dependency and make it available in the target platform. That's why I attached the changes as patch.
Comment 2 Eike Stepper CLA 2010-08-06 08:52:43 EDT 
The patch was out of sync but please go ahead and commit. I'll take a look from time to time ;-)
Comment 3 Martin Fluegge CLA 2010-08-06 11:32:45 EDT 
Created attachment 176047 [details]
Patch v2

Ah, I see. I had changed the buckminster.cspec during another commit. For good order's sake I fixed the patch :)

Committed to HEAD.
Comment 4 Martin Fluegge CLA 2010-08-06 11:38:02 EDT 
Closed. If I do it again wrong, please re-open. 

But I promise that I'll handle this topic more carefully in the future ;)
Comment 5 Eike Stepper CLA 2011-06-23 03:40:54 EDT 
Available in R20110608-1407