321069 – ASTWriter fails on IASTDeclarators with nested declarators

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321069 - ASTWriter fails on IASTDeclarators with nested declarators

Summary: ASTWriter fails on IASTDeclarators with nested declarators

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-core (show other bugs)
Version:	7.0
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	7.0.1
Assignee:	Elena Laskavaia
QA Contact:	Doug Schaefer

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-07-27 17:39 EDT by Tomasz Wesolowski
Modified:	2011-01-06 03:23 EST (History)
CC List:	2 users (show)

See Also:

Attachments
test case (1.01 KB, patch) 2010-07-27 17:39 EDT, Tomasz Wesolowski	no flags	Details \| Diff
fix (937 bytes, patch) 2010-07-27 17:40 EDT, Tomasz Wesolowski	elaskavaia.cdt: iplog+	Details \| Diff
test case (928 bytes, patch) 2010-07-27 18:54 EDT, Tomasz Wesolowski	elaskavaia.cdt: iplog+	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tomasz Wesolowski

2010-07-27 17:39:07 EDT

Some complex declarators are written improperly because simple IASTDeclarators' nested declarators are ignored (as opposed to IASTArrayDeclarators or IASTFunctionDeclarators).

Comment 1 Tomasz Wesolowski

2010-07-27 17:39:28 EDT

Created attachment 175360 [details]
test case

Comment 2 Tomasz Wesolowski

2010-07-27 17:40:31 EDT

Created attachment 175361 [details]
fix

one small line for code, one giant difference for tests

Comment 3 Tomasz Wesolowski

2010-07-27 18:54:25 EDT

Created attachment 175362 [details]
test case

accidentally slipped bug 319044 test into the patch; fixed

Comment 4 Elena Laskavaia

2010-08-01 19:52:12 EDT

I think it should go to 7.0.1

Comment 5 CDT Genie

2010-08-01 20:23:02 EDT

*** cdt cvs genie on behalf of elaskavaia ***
Bug 321069 ASTWriter fails on IASTDeclarators with nested declarators, patch from Tomasz Wesolowski

[*] DeclaratorWriter.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/astwriter/DeclaratorWriter.java?root=Tools_Project&r1=1.7&r2=1.8

[*] ASTWriterDeclaratorTestSource.awts 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/resources/rewrite/ASTWriterDeclaratorTestSource.awts?root=Tools_Project&r1=1.5&r2=1.6

[*] DeclaratorWriter.java 1.6.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/astwriter/DeclaratorWriter.java?root=Tools_Project&r1=1.6&r2=1.6.2.1

[*] ASTWriterDeclaratorTestSource.awts 1.4.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/resources/rewrite/ASTWriterDeclaratorTestSource.awts?root=Tools_Project&r1=1.4&r2=1.4.2.1

Comment 6 Elena Laskavaia

2010-08-01 21:43:56 EDT

I think it should go to 7.0.1

Comment 7 Elena Laskavaia

2010-08-01 21:44:30 EDT

patch applied to 7.0.1 and 8.0, thanks

Comment 8 CDT Genie

2011-01-06 03:23:01 EST

*** cdt cvs genie on behalf of egraf ***
Bug 321069 - ASTWriter fails on IASTDeclarators with nested declarators
Test failed in 7.0

[*] ASTWriterDeclaratorTestSource.awts 1.4.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/resources/rewrite/ASTWriterDeclaratorTestSource.awts?root=Tools_Project&r1=1.4.2.1&r2=1.4.2.2