Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321042 - visibility for specific output broken if output format contains a slash
Summary: visibility for specific output broken if output format contains a slash
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BIRT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7.1   Edit
Assignee: Xuelan Li CLA
QA Contact: Xiaoying Gu CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-27 11:56 EDT by Sven Rieckhoff CLA
Modified: 2011-07-08 02:49 EDT (History)
2 users (show)

See Also:


Attachments
visibility test (4.23 KB, application/octet-stream)
2010-07-29 07:12 EDT, Sven Rieckhoff CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Rieckhoff CLA 2010-07-27 11:56:21 EDT
Build Identifier: 2.6.0

We have a custom emitter for a specific format and the format String contains a slash, e.g. "my/format". Since Birt 2.5.x such a format String breaks the visibility evaluation in ReportEngine: when configuring to "Hide Element" for output "my/format" then no visibility rules at all are applied for this report item.

Reproducible: Always

Steps to Reproduce:
1. Create report with some report item (e.g. Text)
2. Configure visibility: hide element for outputs "html" and "pdf"
3. Goto XML Source and add a rule for "my/format" (workaround for having such a emitter:
                <structure>
                    <property name="format">my/format</property>
                    <expression name="valueExpr" type="javascript">true</expression>
                </structure>
4. Do preview / view report as PDF

Expected result:
Visibility rules does take effect - report item is hidden.

Actual result:
Visibility rules does NOT take effect - report item is visible (same in custom emmitter).
Comment 1 Jun Ouyang CLA 2010-07-29 05:54:24 EDT
This bug can't be reproduced on latest build.
Comment 2 Sven Rieckhoff CLA 2010-07-29 07:12:07 EDT
Created attachment 175484 [details]
visibility test

Attached a test report containing 2 text report items:
 - first not visibile for html, pdf, my/format
 - second not visible for html, pdf

result: first is always visible (obviously wrong), second not visible for html and pdf output

tested with build 2_6_1-N20100729
Comment 3 Jun Ouyang CLA 2010-07-30 01:44:38 EDT
It's reproducible with the report.
Comment 4 Jun Ouyang CLA 2010-08-09 03:52:44 EDT
Will add restriction that the name of format must follow the java identifier convention. That is, a format must begin with a letter, the dollar sign "$", or the underscore character "_". Subsequent characters may be letters, digits, dollar signs, or underscore characters.

Please follow this convention.
Comment 5 Xuelan Li CLA 2011-07-08 02:49:21 EDT
fixed. Now error is shown when format contains illegal characters.