Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321028 - make eclipse.convert available
Summary: make eclipse.convert available
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: 4.3 M7   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 324682
  Show dependency tree
 
Reported: 2010-07-27 10:45 EDT by Paul Webster CLA
Modified: 2013-04-29 18:02 EDT (History)
4 users (show)

See Also:


Attachments
source of converter plugin (17.46 KB, application/octet-stream)
2012-07-20 00:13 EDT, David Williams CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-07-27 10:45:42 EDT
One of our goals was to make e4 SDK builds runnable from anywhere, but if I run it in my eclipse SDK it fails on eclipse.convert.

Could we make that installable from somewhere in 3.7, since it's needed for a build? (it's currently part of the releng.basebuilder).

PW
Comment 1 Kim Moir CLA 2010-07-27 10:57:24 EDT
This task is provided by org.eclipse.jdt.core.contrib.converter_1.1.2.200703120901.jar
which Olivier wrote.  It's currently stored in basebuilder.  Where do you want it to reside, in a repo, as a standalone jar available via wget or CVS?
Comment 2 Paul Webster CLA 2010-07-27 11:01:14 EDT
There's also generateExcludeList

One possibility would be to provide a repo for the tasks used in the eclipse SDK build (Olivier's plugin, genereateExcludeList, etc).

Then if people want to do in-eclipse builds, they would need to install the eclipse build support tasks.

PW
Comment 3 David Williams CLA 2012-07-12 23:40:08 EDT
I've been analysing the basebuilder, saw this converter bundle "stand out". I can see what its used for (summarize compile logs) but I can not find the source anywhere (and, it is not "in" the bundle). 

Adding Olivier to CC ... any ideas where the source might be? 

I've scoured both git repos and old cvs ones and can only see the jar form. 

Happen to have it (still) in any old workspaces? If not, we can always reverse engineer it or write a new "summarize logs" ant task. I know I did one for WTP ... that's not quite as "summarizing" as the one in Eclipse, but similar idea. 
For example of output, see 
http://download.eclipse.org/webtools/downloads/drops/R3.4.0/R-3.4.0-20120612174739/compileResults.php
Comment 4 Olivier Thomann CLA 2012-07-19 10:57:24 EDT
I sent the code to David.
Comment 5 David Williams CLA 2012-07-19 23:48:13 EDT
(In reply to comment #4)
> I sent the code to David.

Thanks very much Olivier. Looks like standard stuff so worth putting in repo, building it, etc. I will rename the packages to be more in-line with "releng" ... such as "org.eclipse.releng.converter" or similar but will likely be a month or so before I get to it. But, good to know we won't have to reinvent it.
Comment 6 David Williams CLA 2012-07-20 00:13:17 EDT
Created attachment 218964 [details]
source of converter plugin

In the spirit of open development, attaching the source here. 

Keep in mind this might not even be exactly what we are currently using and might not be exactly what we end up with ... I just didn't want to seem like we were holding back even though only "build only" code.
Comment 7 Olivier Thomann CLA 2012-07-20 12:16:28 EDT
I am available if needed to make some cleanup. This code was written very quickly to meet some needs for the build. It is far from being polished :-(.
Comment 8 David Williams CLA 2013-03-31 00:15:24 EDT
FWIW, I've commited the attached code to Git .. but, with quite a few changes. 

I checked in two bundles, 
org.eclipse.releng.build.tools.convert, and
org.eclipse.releng.build.tools.convert.application

The latter being very small one, to run the former as a true "Eclipse Application" (with all the pre-reqs that assumes) and the former, while a true OSGi bundle, assumes only Ant, so in theory it could be used from ant only, and not Eclipse. I thought it was best to keep it as "pure" as possible, since in some distant day, I could see this becoming a pure "maven bundle" and used directly from Maven ... though no immediate plans for that. 

No features, pom's or "build" yet ... but, just wanted to update current status. 

I _might_ end up combining the "eclipse.convert" ant task in with the other ant tasks we use during a build, currently in a bundle named org.eclipse.build.tools as it was so named in "basebuilder". I'll discuss that bundle in bug 324682.
Comment 9 David Williams CLA 2013-03-31 00:17:33 EDT
Forgot to mention the repo I put it in :/ See 

http://git.eclipse.org/c/platform/eclipse.platform.releng.buildtools.git/tree/bundles
Comment 10 David Williams CLA 2013-04-29 18:02:57 EDT
This task/tool is now available independent of basebuilder. 

You can see 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/plain/eclipse.platform.releng.tychoeclipsebuilder/eclipse/getBaseBuilderAndTools.xml

for how we currently use in Platform builds. 

Even though the script mentions "base builder" and in fact put everything in a directory named like the old base builder, it actually installs a version of the eclipse (binary) platform, and then uses p2Directory to add the 

org.eclipse.releng.build.tools.feature.feature.group

to that platform (which contains convert ant task and other tools we used to get only from "basebuilder"). 

I currently keep the repo for it on build machine, at 
http://build.eclipse.org/eclipse/buildtools/

And, to be honest, just copy over by hand the repo that's created from the Hudson build job (that builds the tools), which is at 

https://hudson.eclipse.org/hudson/view/Eclipse%20and%20Equinox/job/Eclipse%20Build%20Tools/

Much room for future improvement, but I think enough done to count this as fixed.