Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320984 - save/serialize takes ages
Summary: save/serialize takes ages
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 1.0.0   Edit
Hardware: PC Windows Vista
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 333976
Blocks:
  Show dependency tree
 
Reported: 2010-07-27 04:47 EDT by Ed Willink CLA
Modified: 2017-10-31 11:30 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2010-07-27 04:47:52 EDT
The org.eclipse.ocl.examples.xtext.tests plugin provides JUnit tests for the MDT/OCL Xtext editors. Running org.eclipse.ocl.examples.xtext.tests (standalone).launch on the Helios release, the testLoad_RoyalAndLoyal.ocl takes over 60 seconds when at most 1 would be reasonable. This slow performance was not always observable in all the M6/M7/RCx releases.

Having changed the MDT/OCL grammar, the save of another file now takes forever seemingly, although debugging suggests some progress is being made.
Comment 1 Moritz Eysholdt CLA 2011-01-11 09:49:00 EST
bug 333976 proposes to solve this, since it gets rid of the backtracking algorithm.
Comment 2 Moritz Eysholdt CLA 2011-10-18 04:13:28 EDT
This issue should be solved with the new serializer. Ed, could you have a look if you find time? The new serializer is enabled when you use the "SerialzierFragment" instead of the "ParseTreeConstructorFragment" in your workflow.
Comment 3 Ed Willink CLA 2011-10-18 04:41:23 EDT
(In reply to comment #2)
> This issue should be solved with the new serializer. Ed, could you have a look
> if you find time? The new serializer is enabled when you use the
> "SerialzierFragment" instead of the "ParseTreeConstructorFragment" in your
> workflow.

What code release? Indigo, M2, N-build ?
Comment 4 Moritz Eysholdt CLA 2011-10-18 04:44:01 EDT
> What code release? Indigo, M2, N-build ?

N-build for now, and release 2.1.0 which will be available in time for EclipseCon (in two weeks)
Comment 5 Ed Willink CLA 2011-10-19 05:00:54 EDT
(In reply to comment #2)
> This issue should be solved with the new serializer. Ed, could you have a look
> if you find time? The new serializer is enabled when you use the
> "SerialzierFragment" instead of the "ParseTreeConstructorFragment" in your
> workflow.

I thought this problem had been solved before Indigo; certainly my 'takes ages' problems went away and uncommenting a few save's in JUnit tests now makes no difference.

So I'm not sure that I can confirm that the new serializer is good, but in the interests of moving on, I tried updating my 4.2.0.I20111007-1625 installation with tmf-xtext-Update-N201110171027. Total disaster; The 'Outline', 'Editor' and 'Miscellaneous' areas of the UI are blank; only the 'Explorer' area is shown. Attempting to show view Error Log gives an NPE on some Injection class. And just to make matters more fun Revert Configuration doesn't work either.

Since 4.2M2 was fragile, and I've already got an improved Platform and UML2, I think I'll have to leave trying this till M3 when hopefully things will come together again.
Comment 6 Ed Willink CLA 2011-10-19 05:35:00 EDT
(In reply to comment #5)
> And just to make matters more fun Revert Configuration doesn't work either.

But after killing it and Restarting, I have an updated installation after all.

Before changing, editors regenerate and work as before.

After changing I now get missing genmodel error messages. I'll investigate, but it looks as if you're not following the usedGenPackages closure.
Comment 7 Ed Willink CLA 2012-06-26 09:14:30 EDT
Hi Moritz.

Just found this on my 'action required' stack. I think we got this all sorted at/just after EclipCon NA. So resolved fixed??
Comment 8 Moritz Eysholdt CLA 2012-06-26 09:47:03 EDT
(In reply to comment #7)
> Just found this on my 'action required' stack. I think we got this all sorted
> at/just after EclipCon NA. So resolved fixed??

Yes. Thanks for getting back on this.
Comment 9 Eclipse Webmaster CLA 2017-10-31 11:30:53 EDT
Requested via bug 522520.

-M.