Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320966 - FileDiff class should use DiffFormatter more directly
Summary: FileDiff class should use DiffFormatter more directly
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.9.0-M2   Edit
Assignee: Stefan Lay CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-26 19:31 EDT by Shawn Pearce CLA
Modified: 2010-08-16 20:07 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Pearce CLA 2010-07-26 19:31:18 EDT 
Latest JGit supports doing all of the diff formatting inside of the DiffFormatter class, especially the file header.  We should be reusing that code rather than having an outdated copy.
Comment 1 Stefan Lay CLA 2010-07-27 06:54:52 EDT 
Great, I'll do that.
Comment 2 Stefan Lay CLA 2010-08-13 11:15:16 EDT 
Code review at http://egit.eclipse.org/r/#change,1303
Comment 3 Chris Aniszczyk CLA 2010-08-16 12:38:02 EDT 
Pushed part of this change via dac60da0ec8882d7da32c6d2f93ed9f6f81b60fa.
Comment 4 Chris Aniszczyk CLA 2010-08-16 20:07:32 EDT 
Fixed with 7445a9123e5a7f4b85be94af8d00fbfb50d8bade.

Thanks!