Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320946 - Bad comparison in ProfileBundleContainer.isContentEqual()
Summary: Bad comparison in ProfileBundleContainer.isContentEqual()
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6.1   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2010-07-26 14:39 EDT by Michael Rennie CLA
Modified: 2010-08-30 12:58 EDT (History)
2 users (show)

See Also:
darin.eclipse: review+

Attachments
fix (1008 bytes, patch)
2010-07-26 14:39 EDT, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2010-07-26 14:39:21 EDT 
Created attachment 175256 [details]
fix

build: I20100720-0800

The comparison in ProfileBundleContainer.isContentEqual() is bunk. You are comparing the same object against itself.

bunk code:

if (container instanceof ProfileBundleContainer) {
  ProfileBundleContainer pbc = (ProfileBundleContainer) container;
  return fHome.equals(pbc.fHome) && 
         isNullOrEqual(fConfiguration, fConfiguration);
}

Should probably be comparing to pbc.fConfiguration
Comment 1 Curtis Windatt CLA 2010-07-26 15:20:20 EDT 
Thanks Mike. Fixed in HEAD.
Comment 2 Curtis Windatt CLA 2010-07-27 15:58:00 EDT 
Reopening as a 3.6.1 candidate
Comment 3 Curtis Windatt CLA 2010-07-27 15:59:17 EDT 
Fixed in 3.6.1 Branch
Comment 4 Curtis Windatt CLA 2010-08-30 12:58:51 EDT 
Verified.