Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320938 - [ModelTooling] Design-Time image preview not working
Summary: [ModelTooling] Design-Time image preview not working
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 4.1 M1   Edit
Assignee: Thomas Schindl CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-26 13:23 EDT by Thomas Schindl CLA
Modified: 2010-07-26 15:09 EDT (History)
1 user (show)

See Also:

Attachments
patch (1.50 KB, text/plain)
2010-07-26 13:46 EDT, Thomas Schindl CLA 		no flags Details
patch (1.41 KB, patch)
2010-07-26 13:46 EDT, Thomas Schindl CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2010-07-26 13:23:59 EDT 
The design time image preview is not working (hovering shows that the url has not been loaded). Looks like I missed that because I always has the Contacts-Bundle in my workspace when launch in an inner.
Comment 1 Thomas Schindl CLA 2010-07-26 13:46:09 EDT 
Created attachment 175245 [details]
patch
Comment 2 Thomas Schindl CLA 2010-07-26 13:46:56 EDT 
Created attachment 175246 [details]
patch
Comment 3 Thomas Schindl CLA 2010-07-26 14:03:05 EDT 
I should probably explain in more detail what is done here. When one hovers an Image-URI in the editor I'm showing the image in a tooltip.

The problem is that I'm currently only looking up the image in the running OSGi-Instance which is the IDE. This is fine in the live-preview but fails at design time because there the image has to be looked up in workspace-projects.

The patch fixes this temporarily by trying to resolve the image in the workspace if looking up in the running instance fails.

I know this is not a blocking issue though.
Comment 4 Thomas Schindl CLA 2010-07-26 14:14:42 EDT 
In case I get the +1 from Boris - Remy can you review it ;-)
Comment 5 Boris Bokowski CLA 2010-07-26 14:18:47 EDT 
(In reply to comment #3)
> I know this is not a blocking issue though.

Then let's defer this until after the release.
Comment 6 Thomas Schindl CLA 2010-07-26 15:04:12 EDT 
ok. I've created a new branch and committed those small fixes there.
Comment 7 Thomas Schindl CLA 2010-07-26 15:09:34 EDT 
released to post_40_release branch