Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320937 - jar's placed in Java EE 5 Ear's lib directory should never be considered "modules"
Summary: jar's placed in Java EE 5 Ear's lib directory should never be considered "mod...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.0.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Hari Shankar CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-26 13:23 EDT by Hari Shankar CLA
Modified: 2010-08-10 14:09 EDT (History)
2 users (show)

See Also:
cbridgha: review+
jsholl: review+

Attachments
Patch (9.16 KB, patch)
2010-07-26 13:25 EDT, Hari Shankar CLA 		no flags Details | Diff
updated patch (9.18 KB, patch)
2010-07-28 15:15 EDT, Hari Shankar CLA 		no flags Details | Diff
Patch (7.35 KB, patch)
2010-08-05 14:47 EDT, Hari Shankar CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hari Shankar CLA 2010-07-26 13:23:51 EDT 
Build Identifier: 321

This bug is a clone of bug 320436. 

This bug introduces changes that ensure that when an external jar with a main class in its manifest is added via the deployment assembly page, 

a) it shows up properly under the utility jars node in enterprise explorer, and
b) deploys as a utility jar (instead of a module) onto the server.

Reproducible: Always
Comment 1 Hari Shankar CLA 2010-07-26 13:25:20 EDT 
Created attachment 175244 [details]
Patch

Patch Attached.
Comment 2 Hari Shankar CLA 2010-07-28 15:15:38 EDT 
Created attachment 175437 [details]
updated patch

Updated the patch to handle case where the earLibDir variable is null in JavaEEArchiveUtilities.
Comment 3 Chuck Bridgham CLA 2010-08-04 17:03:50 EDT 
approved
Comment 4 Jason Sholl CLA 2010-08-05 10:29:14 EDT 
Hari, please use the EARUtilities.getEARLibDir() method for 3.2.2 instead of creating a new utility for this.
Comment 5 Hari Shankar CLA 2010-08-05 14:47:21 EDT 
Created attachment 175969 [details]
Patch

Updated with Jason's comment.
Comment 6 Hari Shankar CLA 2010-08-10 12:33:18 EDT 
Jason, could you please review this and release? Thanks.
Comment 7 Jason Sholl CLA 2010-08-10 14:09:36 EDT 
code checked into head for wtp 3.2.2