Community
Participate
Working Groups
Currently, the only way to make use of SWTGefBot (SWTBotGefEditPart and the like) is when you have an editor with a graphical viewer. It is impossible to access a view with a graphical viewer, since SWTBotGefEditor subclasses SWTBotEditor. We should probably find a better way then this, since there is no obvious reason why those GEF utilities should depend on IWorkbenchReference (be it an editor or a view). I suggest something along these lines: instead of having a SWTBotGefEditor, let's have a SWTBotGefViewer. It doesn't subclass SWTBotEditor (nor SWTBotWorkbencPart), and it's constructor would be: SWTBotGefViewer(GraphicalViewer viewer, SWTGefBot bot). Everything else is exactly the same, except that you won't need to reimplement the isActive() and setFocus(), and the init method won't need to find the GraphicalViewer. I would also provide one factory method to create a SWTBotGefViewer, which would take a SWTBotWorkbenchPart as a parameter, it would look something like: public SWTBotGefViewer foo(SWTBotWorkbenchPart part) { GraphicalViewer viewer = (GraphicalViewer) part.getAdapter(GraphicalViewer.class); return new SWTBotGefViewer(viewer, new SWTGefBot()); } Of course, SWTBotWorkbenchPart#getAdapter(Class) would need to be abstract and implemented in both SWTBotEditor and SWTBotView to forward to their proper part. What do you think? On a (somewhat) unrelated note: why is SWTBotEditor#setFocus() implementation empty? Shouldn't we "pull up" the implementation of SWTBotGefEditor#setFocus()?
Hey, hey, I never stop improving: public SWTBotGefViewer gefViewer(String partName){ SWTBotWorkbenchPart part; // Search for views or editors that match partName and assign the result to part. Still haven't found how to do this magic though :P GraphicalViewer viewer = (GraphicalViewer) part.getAdapter(GraphicalViewer.class); return new SWTBotGefViewer(viewer, new SWTGefBot()); } Then, you, as the user of this API, don't even need to care if it's an editor or a view, you only need to know its name.
Created attachment 176509 [details] Proposed change As no one complained, I thought I might as well do it ;) So here it is. Main changes are that SWTBotGefEditor is now deprecated in profit of SWTBotGefViewer, which now works with a GraphicalViewer only, no IEditorReference required! All public method from SWTBotGefEditor now delegates to a SWTBotGefViewer. I also changed the unit tests to use the new class instead of the old one. While I was doing this, I took the liberty to make some clean-up to the code and translated everything to JUnit 4 style. Everything's much clearer now! O, and all the tests still pass ;) Enjoy! p.s.: I did the patch using git diff. If there's a problem with it, let me now.
Thanks for the patch ! Committed with some minor modifications (I created a SWTBotGefView which is currently empty and wrap the viewer). Revision 603.
