Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320908 - [Model Explorer] Newly created objects (via "New Child" menu) shall get focus and be in rename mode
Summary: [Model Explorer] Newly created objects (via "New Child" menu) shall get focus...
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Views (show other bugs)
Version: 1.0.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: SR2   Edit
Assignee: Gabriel Pascual CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 419461 (view as bug list)
Depends on: 335835
Blocks:
  Show dependency tree
 
Reported: 2010-07-26 10:01 EDT by Yann Tanguy CLA
Modified: 2015-02-16 11:25 EST (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yann Tanguy CLA 2010-07-26 10:01:44 EDT 
Newly created objects (via "New Child" menu) shall get focus and be in rename mode
Comment 1 Yann Tanguy CLA 2011-01-31 07:11:28 EST 
In r3629 :
- Select newly created element (after "Create child" command).

Uses ModelExplorerView#revealSemanticElement() which does not work correctly for now (it was in 0.7.X, but it seem we have a regression in trunk).
Comment 2 Patrick Tessier CLA 2011-02-09 10:56:06 EST 
this bug is not valid anymore in the version 0.8.X
Comment 3 Yann Tanguy CLA 2011-02-10 04:34:29 EST 
(In reply to comment #2)
> this bug is not valid anymore in the version 0.8.X

The bug related to selection and focus on the new element is fixed.
But the auto "rename mode" on newly created element still need to be implemented.
Comment 4 Camille Letavernier CLA 2013-07-05 12:14:37 EDT 
In 0.10.0, the newly created element is not selected.
It is not in edit mode either.
Comment 5 Toni Siljamäki CLA 2013-10-08 05:47:32 EDT 
I agree that this is an important usability issue.
Comment 6 Camille Letavernier CLA 2014-03-11 08:52:13 EDT 
I'm currently working on this one.

Current state:

- Improve the "select & reveal" method in the ModelExplorer, to ensure that it is properly refreshed before trying to select new element (To avoid the sequence Element created -> Try to select -> Element displayed: the element cannot be selected because it is not displayed yet). This doesn't prevent the asynchronous/lazy refresh of the ModelExplorer and doesn't impact performances
- Call "Select & reveal" after the creation of elements from the New Child menu

The newly created element is not in "rename" mode, because the rename action from the ModelExplorer is a blocking dialog, which may "Interrupt the flow". However, the element is selected in the Properties view and may be renamed from there.

I will push the branch after M6, as this required non-trivial changes on the ModelExplorer implementation.

Implemented in commit cf1d28e, branch bugs/320908-selectNewChild
Comment 7 Camille Letavernier CLA 2014-04-29 09:54:20 EDT 
Fixed in 8ac0c59 on master, except for this part:

> The newly created element is not in "rename" mode, because the rename action from the ModelExplorer is a blocking dialog, which may "Interrupt the flow". However, the element is selected in the Properties view and may be renamed from there.

which will not be implemented
Comment 8 Camille Letavernier CLA 2014-05-15 04:06:38 EDT 
*** Bug 419461 has been marked as a duplicate of this bug. ***
Comment 9 Ronan Bar CLA 2015-02-12 05:54:36 EST 
Has there been a regression here? This stopped working a while back. On today's build on Luna (on Ubuntu 14.0.4) it certainly does not work.
Comment 10 Camille Letavernier CLA 2015-02-12 06:56:50 EST 
The fix has been overridden when the new "New child" menu implementation has been pushed in Luna. It hasn't been restored since then
Comment 11 Camille Letavernier CLA 2015-02-16 11:25:31 EST 
Fix backported on Maintenance/Luna: https://git.eclipse.org/r/#/c/41827/

I close the task