Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320872 - Auto Insertion of brackets is buggy
Summary: Auto Insertion of brackets is buggy
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P1 major (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact: Ilina Stefanova CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-26 04:34 EDT by Pavel Galaton CLA
Modified: 2020-05-14 11:08 EDT (History)
3 users (show)

See Also:

Attachments
video that shows problem (86.92 KB, application/octet-stream)
2010-07-26 04:53 EDT, Pavel Galaton CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Galaton CLA 2010-07-26 04:34:47 EDT 
Build Identifier: 20100617-1415

when you insert manually '}' in statements that has > 1 depth 
then auto insertion is totally wrong.

Reproducible: Always

Steps to Reproduce:
1. see video
Comment 1 Pavel Galaton CLA 2010-07-26 04:44:39 EDT 
<?php
$a = 1;
if($a === 1) {
	$b=13;	
	$c=13;	
	if($b == 13) {
	|
}

insert '}' on '|' and you will see problem.
something happening with bug tracker , cant upload video add comment, this is 5th comment i've added
Comment 2 Pavel Galaton CLA 2010-07-26 04:53:40 EDT 
Created attachment 175204 [details]
video that shows problem
Comment 3 Pavel Galaton CLA 2010-07-26 05:15:00 EDT 
something really bad happened :(

<?php
if(true) {
	|
}

copy
if(true) {
	
}

and paste it to '|'

---------

if(true) {
	if(true) {
		$var = |
	}
}

copy 'true' from second if statement and paste to '|' it inserts additional tabs
more depth more tabs inserted
Comment 4 Zhongwei Zhao CLA 2010-08-01 23:07:38 EDT 
Hi,

I got this issue,I will fix it asap:)
Comment 5 Zhongwei Zhao CLA 2010-08-02 03:48:22 EDT 
fixed in head,thanks for your reporting!
Comment 6 Sylvia Tancheva CLA 2010-09-02 06:00:02 EDT 
Should be verified in PDT 2.3
Comment 7 Ilina Stefanova CLA 2011-08-03 02:47:06 EDT 
Verified.