Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320814 - Minimized stacks are 'restored' on shutdown
Summary: Minimized stacks are 'restored' on shutdown
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 major (vote)
Target Milestone: 1.0 RC3   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-24 12:34 EDT by Eric Moffatt CLA
Modified: 2010-07-27 13:56 EDT (History)
2 users (show)

See Also:
emoffatt: review?

Attachments
Remove the dispose listener (1.40 KB, patch)
2010-07-24 12:37 EDT, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2010-07-24 12:34:09 EDT 
Fire up a fresh inner
minimize both the Package Explorer and Outline view stacks
close and re-open

they've been magically 'restored'

This is cause by a rempant widget disposed listener added while trying to fix bug 320243.
Comment 1 Eric Moffatt CLA 2010-07-24 12:37:11 EDT 
Created attachment 175157 [details]
Remove the dispose listener


I've retested the scenarios and are all still correctly handled by changes made to the MinMaxAddon's event handling...
Comment 2 Boris Bokowski CLA 2010-07-24 16:56:18 EDT 
I've done some testing (and found steps with which I can reproduce bug 320813 while running with this patch) but I don't think this patch made it worse. So +1, the patch looks ok to me.
Comment 3 Eric Moffatt CLA 2010-07-24 17:01:19 EDT 
Committed in >20100725. Applied the patch.
Comment 4 Eric Moffatt CLA 2010-07-27 13:56:39 EDT 
Verified on XP in I20100726-2152.