Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320810 - Product configuration sets org.eclipse.equinox.ds startlevel to 1 instead of 2
Summary: Product configuration sets org.eclipse.equinox.ds startlevel to 1 instead of 2
Status: VERIFIED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Buckminster (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: buckminster.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-24 10:00 EDT by Peter Nehrer CLA
Modified: 2019-02-25 14:39 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Nehrer CLA 2010-07-24 10:00:34 EDT 
When generating the product configuration, Buckminster's ProductAction defaults the start level of bundle org.eclipse.equinox.ds to 1:

	private BundleInfo[] getDefaultStartInfo() {
		BundleInfo[] defaults = new BundleInfo[6];
		defaults[0] = new BundleInfo(BUNDLE_SIMPLE_CONFIGURATOR, null, null, 1, true);
		defaults[1] = new BundleInfo(BUNDLE_EQUINOX_COMMON, null, null, 2, true);
		defaults[2] = new BundleInfo(BUNDLE_OSGI, null, null, -1, true);
		defaults[3] = new BundleInfo(BUNDLE_UPDATE_CONFIGURATOR, null, null, 4, true);
		defaults[4] = new BundleInfo(BUNDLE_CORE_RUNTIME, null, null, 4, true);
		defaults[5] = new BundleInfo(BUNDLE_DS, null, null, 1, true);
		return defaults;
	}

In Helios, PDE changed the startlevel of that bundle to 2.

See http://help.eclipse.org/helios/index.jsp?topic=/org.eclipse.pde.doc.user/tasks/pde_p2_configuringproducts.htm

Note that the product file correctly sets the startlevel of that bundle to 2, but it seems to be ignored/overriden by Buckminster. 
E.g.,

   <configurations>
      <plugin id="org.eclipse.core.runtime" autoStart="true" startLevel="0" />
      <plugin id="org.eclipse.equinox.cm" autoStart="true" startLevel="0" />
      <plugin id="org.eclipse.equinox.common" autoStart="true" startLevel="2" />
      <plugin id="org.eclipse.equinox.ds" autoStart="true" startLevel="2" />
   </configurations>

Ideally, these explicitly-provided values would be honored.
Comment 1 Thomas Hallgren CLA 2010-07-27 06:07:36 EDT 
I fixed so that:

1. Configurations in the .product file will override the defaults.
2. The default for org.eclipse.equinox.ds is now 2 instead of 1.

The fix was committed to helios-maintenance, rev 11530.
Comment 2 Peter Nehrer CLA 2010-07-27 23:00:17 EDT 
Verified, thanks!