Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320791 - NPE on workbench shutdown
Summary: NPE on workbench shutdown
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 blocker (vote)
Target Milestone: 1.0 RC3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 320820 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-07-24 04:50 EDT by Thomas Schindl CLA
Modified: 2010-07-27 13:38 EDT (History)
4 users (show)

See Also:
remy.suen: review+
tom.schindl: review+

Attachments
fix (921 bytes, patch)
2010-07-24 14:07 EDT, Boris Bokowski CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2010-07-24 04:50:40 EDT 
This happens for me on rc3 when shuting down:

java.lang.NullPointerException
        at org.eclipse.e4.ui.internal.workbench.SelectionServiceImpl.notifyListeners(SelectionServiceImpl.java:192)
        at org.eclipse.e4.ui.internal.workbench.SelectionServiceImpl.access$3(SelectionServiceImpl.java:191)
        at org.eclipse.e4.ui.internal.workbench.SelectionServiceImpl$2.changed(SelectionServiceImpl.java:230)
        at org.eclipse.e4.core.internal.contexts.TrackableComputationExt.update(TrackableComputationExt.java:95)
        at org.eclipse.e4.core.internal.contexts.EclipseContext.processScheduled(EclipseContext.java:333)
        at org.eclipse.e4.core.internal.contexts.EclipseContext.set(EclipseContext.java:350)
        at org.eclipse.e4.ui.internal.workbench.swt.ShellActivationListener$2.run(ShellActivationListener.java:127)
        at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
        at org.eclipse.e4.ui.internal.workbench.swt.ShellActivationListener.activate(ShellActivationListener.java:124)
        at org.eclipse.e4.ui.internal.workbench.swt.ShellActivationListener.handleEvent(ShellActivationListener.java:74)
Comment 1 Boris Bokowski CLA 2010-07-24 14:06:30 EDT 
*** Bug 320820 has been marked as a duplicate of this bug. ***
Comment 2 Boris Bokowski CLA 2010-07-24 14:07:33 EDT 
Created attachment 175161 [details]
fix
Comment 3 Remy Suen CLA 2010-07-24 14:17:42 EDT 
Will need to figure out why the part hasn't been disposed yet.
Comment 4 Thomas Schindl CLA 2010-07-24 17:02:23 EDT 
I agree with Remy so probably we should add a comment to check why this is happening
Comment 5 Boris Bokowski CLA 2010-07-24 17:24:14 EDT 
Patch committed to HEAD. Remy, how do you want to remind ourselves that there is something not quite right?
Comment 6 Remy Suen CLA 2010-07-24 17:28:20 EDT 
(In reply to comment #5)
> Patch committed to HEAD. Remy, how do you want to remind ourselves that there
> is something not quite right?

I spun a bug 320828.
Comment 7 Eric Moffatt CLA 2010-07-27 13:38:45 EDT 
I don't see this on XP with I20100726-2152...