Community
Participate
Working Groups
The classic css is missing the following features: - blue gradient for active tabs - white gradient for inactive tabs - ability to properly wrap the toolbar when the highlight header is present - get rid of the dark perspective switcher line
Boris, I have a patch that fixes the toolbar sizing/wrapping issue (along with all of the other outstanding issues). I'd like Silenio to take a look at it on Monday just to be extra careful and we can decide then if we want it in.
Created attachment 175271 [details] SWT toolbar height patch SWT code for classic styling
Created attachment 175278 [details] Handler for setting selection background color This patch lets you set the CTabFolder selection color from CSS.
Created attachment 175279 [details] CSS changes
the first patch (SWT toolbar height) has been committed by Bogdan. I checked that the toolbar wrapping is working properly. However we are still tweaking the color gradients needed so that unselected tab gradient flows properly into the view toolbar below...
Created attachment 175282 [details] Latest CSS for Classic
is the space in the theme intentional?
committed stylesheets and CSS handler (last two patches) to HEAD
(In reply to comment #7) > is the space in the theme intentional? Which space do you mean, specifically? A space character somewhere in a file or filenam, or visual space?
Take a look at: -----8<----- basestylesheeturi="css/ e4_classic_win7.css" -----8<----- which is wrong most likely
We are seeing an NPE on shutdown that I didn't catch before committing. Investigating.
(In reply to comment #10) > Take a look at: > > -----8<----- > basestylesheeturi="css/ e4_classic_win7.css" > -----8<----- > > which is wrong most likely we fixed this in HEAD, thanks for spotting Tom.
we were seeing an NPE on shutdown because the GUI was being removed, the renderer was null, but a layout (and therefore skinning event) happened during this time. The NPE was because the renderer was null. Bogdan and I debated whether to: - revert the last two patches in this bug, and go back to having the wrong selection color - surgically fix the NPE's with null checks - get to the bottom of the timing problem by understanding how you get in this state. And also... why are we just seeing this, what does it have to do with this fix? We convinced ourselves that: - the reason the NPE was just showing up is that nowhere else in the stylesheets had we been messing with the tab selection background, therefore we had not previously called this CTabFolder API while in skinning events. - the proper fix is not to use a null check, but to check the CTabFolder "inDispose" flag which is used internally when an event is received between the time the dispose event is received and actual disposal happens. This flag is used in other places (such as paint, etc.) to ensure that renderer code is not invoked - we need to understand better why the layout/reskin occurs during the removeGUI Based on all this, we elected to keep the styling change and add the check on the flag. However it is still worth ensuring that getting the skinning events during a removeGUI is something we can explain to ourselves.
Removing outdated target milestone.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
This is a mass change to close all e4 bugs marked with "stalebug" whiteboard. If this bug is still valid, please reopen and remove the "stalebug" keyword.
