Comment 1 Elias Volanakis 2010-07-23 19:39:25 EDT

Fix here:

http://github.com/elias42/swtbot/commit/dcd42787b649e6730105a7d5a7eb8f2306776306

Comment 2 Ketan Padegaonkar 2010-07-23 20:20:58 EDT

I like your neat stub listener.

Since the listener is notified in another thread, this test may at times generate false failures when the assertion runs on the mock but the UI thread has not notified it yet.

A better alternative IMHO might be something like.

assertWaitForTrue(new DefaultCondition(){
  public boolean test(){
    return listener.whatever;
  }
});


public assertWaitForTrue(condition){
  // throws TimeoutException if the condition fails!
  try{
    bot.waitUntil(condition);
  } catch(TimeoutException e){
    fail("Timed out waiting for listener to be notified!");
  }
}