Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320768 - [releng] No source bundles or source reference header for e4 bundles
Summary: [releng] No source bundles or source reference header for e4 bundles
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.1 M4   Edit
Assignee: Andrew Niefer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 332433 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-07-23 16:06 EDT by Paul Webster CLA
Modified: 2010-12-13 08:32 EST (History)
8 users (show)

See Also:

Attachments
patch (2.05 KB, patch)
2010-11-05 14:04 EDT, Andrew Niefer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-07-23 16:06:10 EDT 
The e4 bundles and  ui.workbench in the 4.0 SDK don't have source bundles ATM.  But they also don't have the eclipse source reference header.  Is there something we need to do so that's generated on build?

PW
Comment 1 Thomas Schindl CLA 2010-07-24 14:35:54 EDT 
That's a major problem if you try to develop e4-RCP applications because not even the .exsd are available without the sources.

Do we address this before we ship?
Comment 2 Boris Bokowski CLA 2010-07-25 01:17:12 EDT 
Marking RC3 so that it shows up in my query.
Comment 3 Paul Webster CLA 2010-07-26 08:36:02 EDT 
It seems that what we build in 4.0 has the source headers, but not what we build in e4.

PW
Comment 4 Paul Webster CLA 2010-07-26 09:36:32 EDT 
I've added generateSourceReferences=true into our e4 build and added the e4 source bundle references to our e4.map file.  We do generate an org.eclipse.e4.rcp.source feature, so I'm hoping the next build will pick up the source bundles from the e4 repository.

PW
Comment 5 Paul Webster CLA 2010-07-27 12:36:19 EDT 
The source is still not provided in 4.0 SDK build.  The source headers are there now, so they can be imported.  I'll look at installing the e4 UI in 4.0

PW
Comment 6 Paul Webster CLA 2010-07-27 13:15:09 EDT 
OK, tested on I20100726-2152 with the update sites.  You can install E4 Modeled Workbench/E4 CSS Support (and their source features) into the 4.0 build (along with EMF SDK and XML Editors and Tools).

From there, you can see the source for the demo app.

PW
Comment 7 Lars Vogel CLA 2010-10-20 16:06:55 EDT 
Looks like the source for "org.eclipse.e4.workbench" is missing in Eclipse 4.1 M2. And it seems that now source feature exists for org.eclipse.e4.workbench.
Comment 8 Remy Suen CLA 2010-11-05 12:33:16 EDT 
M3 has shipped, try again for M4?
Comment 9 Paul Webster CLA 2010-11-05 12:36:54 EDT 
Maybe we're missing the build.properties entry that would include binary source bundles, similar to:

generate.feature@org.eclipse.e4.languages.source.feature=org.eclipse.e4.languages.feature,plugin@org.eclipse.wst.jsdt.core.source;unpack="false",plugin@org.eclipse.wst.jsdt.manipulation.source;unpack="false",plugin@org.eclipse.wst.jsdt.ui.source;unpack="false",plugin@org.mozilla.javascript.source;unpack="false"
Comment 10 Andrew Niefer CLA 2010-11-05 14:04:10 EDT 
Created attachment 182507 [details]
patch

I believe that the problem is just that the fetch doesn't get binary source bundles for us.  This is because at fetch time the source features don't exist yet and fetch isn't smart enough to predict what will go in them.

We should just be able to add a mirror from the 0.11-I-builds repo of the source we want.
Comment 11 Andrew Niefer CLA 2010-11-05 14:32:40 EDT 
Released after fixing small typo in the patch.  Local test build shows the e4.rcp.feature with actual content.
Comment 12 Lars Vogel CLA 2010-12-13 08:32:25 EST 
*** Bug 332433 has been marked as a duplicate of this bug. ***