Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320767 - Usability problems in the Add Archive/External Archive dialog of deployment assembly page
Summary: Usability problems in the Add Archive/External Archive dialog of deployment a...
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: wst.common (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Aidyl Kareh CLA
QA Contact: Carl Anderson CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-23 15:56 EDT by Aidyl Kareh CLA
Modified: 2010-08-10 17:37 EDT (History)
3 users (show)

See Also:
ccc: review+
jsholl: review+


Attachments
Proposed Patch (9.87 KB, patch)
2010-07-23 16:08 EDT, Aidyl Kareh CLA
no flags Details | Diff
Updated UI Screen Capture (45.11 KB, image/jpeg)
2010-07-23 16:10 EDT, Aidyl Kareh CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aidyl Kareh CLA 2010-07-23 15:56:32 EDT
Build Identifier: WTP 3.2.1

There are some usability issues in the Archive/External Archive dialogs since the only button available is a 'Browse...' button. Every time this button is pressed the selected contents will replace any previously selected archives. Also, there is no way that the user can remove 1 or more archives from the listed archive files without having to selecting only the desired archives using the 'Browse...' button.

Steps to reproduce:
1. Open the 'Deployment Assembly' properties page of a project, click on 'Add...' -> 'External Archive'.
2. Click 'Browse...', select an archive and press Open. You are back to the 'Add an External Archive' dialog, and the table lists the archive you selected.
3. Click 'Browse...' again. Click Cancel.
4. The table is now empty (the reference to the first archive is lost)
5. At step 3, if you select another jar instead of clicking Cancel, the second jar is added, but the first jar is lost.

Reproducible: Always
Comment 1 Aidyl Kareh CLA 2010-07-23 16:08:49 EDT
Created attachment 175100 [details]
Proposed Patch

The proposed patch modifies the UI to have 2 buttons ('Add...' and 'Remove') instead of the 'Browse...' button. The 'Add...' button will open the dialog that was previously opened by the 'Browse...' button and it will not remove any previous elements from the Archive References table. The 'Remove' button will allow the user to delete 1 or more elements from the Archive References table. No new strings where introduced. See attached screen capture with new UI.
Comment 2 Aidyl Kareh CLA 2010-07-23 16:10:08 EDT
Created attachment 175102 [details]
Updated UI Screen Capture
Comment 3 Carl Anderson CLA 2010-08-10 16:15:45 EDT
I approve of these changes.
Note that, while the UI changed, there are no translated strings changed, and thus this bug does not require PMC approval at this time.
Comment 4 Jason Sholl CLA 2010-08-10 17:37:36 EDT
code checked into head for WTP 3.2.2