Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320612 - [Discovery] Unit tests fail due to broken detection of external ip address
Summary: [Discovery] Unit tests fail due to broken detection of external ip address
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.test (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.4.0   Edit
Assignee: Markus Kuppe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 320799
Blocks: 318086
  Show dependency tree
 
Reported: 2010-07-22 06:46 EDT by Markus Kuppe CLA
Modified: 2010-07-31 07:40 EDT (History)
0 users

See Also:

Attachments
mylyn/context/zip (4.13 KB, application/octet-stream)
2010-07-24 08:30 EDT, Markus Kuppe CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Kuppe CLA 2010-07-22 06:46:45 EDT 
IServiceInfos are compared for equality based on a couple of properties including the IP address. If the expected IServiceInfo e.g. has "127.0.0.1" set but the discovery provider binds to the external ip address of e.g. "192.168.1.1" the checks fail.
Thus the tests have to take the behavior of the provider into account.
Comment 1 Markus Kuppe CLA 2010-07-24 08:28:21 EDT 
For discovery tests to successfully pass it is important that the local hostname resolution works correctly. Thus /etc/hosts on ecf2 has been changed to include:

127.0.0.1       localhost
127.0.0.1	ecf2
140.211.166.119 ecf2.osuosl.org ecf2
Comment 2 Markus Kuppe CLA 2010-07-24 08:30:44 EDT 
jslp and jmdns tests run successfully now. composite tests are still buggy though. Attaching context of work so far.
Comment 3 Markus Kuppe CLA 2010-07-24 08:30:46 EDT 
Created attachment 175139 [details]
mylyn/context/zip
Comment 4 Markus Kuppe CLA 2010-07-31 07:40:47 EDT 
Fixed composite tests in HEAD too