Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320609 - NPE in ProjectDescription class
Summary: NPE in ProjectDescription class
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Rakesh CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
: 319095 321412 325643 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-07-22 06:32 EDT by Rakesh CLA
Modified: 2010-09-17 15:33 EDT (History)
4 users (show)

See Also:
nsand.dev: review+

Attachments
patch (972 bytes, patch)
2010-07-22 06:34 EDT, Rakesh CLA 		no flags Details | Diff
patch (4.69 KB, patch)
2010-07-28 02:51 EDT, Rakesh CLA 		nsand.dev: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rakesh CLA 2010-07-22 06:32:55 EDT 
Build Identifier: I20100608-0911

If resource is outofsych with local file system , zip returned is null and we get an NPE.

Reproducible: Always
Comment 1 Rakesh CLA 2010-07-22 06:34:22 EDT 
Created attachment 174954 [details]
patch 

Null Pointer check added.
Comment 2 Nick Sandonato CLA 2010-07-27 14:37:29 EDT 
While I know it's probably negligible, instead of checking if zip is null on each iteration of the loop, we only really have to do it once before we enter the loop. Can you please provide an update?
Comment 3 Rakesh CLA 2010-07-28 02:51:12 EDT 
Created attachment 175369 [details]
patch

NP checked outside loop.
Comment 4 Nick Sandonato CLA 2010-07-28 15:29:22 EDT 
Thanks, Rakesh.
Comment 5 Nitin Dahyabhai CLA 2010-07-30 23:18:52 EDT 
*** Bug 321412 has been marked as a duplicate of this bug. ***
Comment 6 Nick Sandonato CLA 2010-08-09 15:32:07 EDT 
Released.
Comment 7 Nitin Dahyabhai CLA 2010-08-26 13:24:35 EDT 
*** Bug 319095 has been marked as a duplicate of this bug. ***
Comment 8 Nitin Dahyabhai CLA 2010-09-17 15:33:03 EDT 
*** Bug 325643 has been marked as a duplicate of this bug. ***