Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320517 - [ContentAssist] Restore JSP attribute value proposals to a more natural order
Summary: [ContentAssist] Restore JSP attribute value proposals to a more natural order
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard: WI51031
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-21 10:43 EDT by Rakesh CLA
Modified: 2010-08-10 16:57 EDT (History)
1 user (show)

See Also:
thatnitind: review+

Attachments
Patch (19.45 KB, patch)
2010-07-21 10:48 EDT, Rakesh CLA 		no flags Details | Diff
patch (1.53 KB, patch)
2010-08-09 17:06 EDT, Nick Sandonato CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rakesh CLA 2010-07-21 10:43:21 EDT 
Build Identifier:  I20100608-0911

Raised for RTC WI-51031
Details copied from there:
DWP with a dojo facet.
Create and open a web page
Do content assist for dojoType in  <div dojoType="">

I see jsp:include, jsp:forward etc along with the other valid dojo types.

Reproducible: Always
Comment 1 Rakesh CLA 2010-07-21 10:48:32 EDT 
Created attachment 174859 [details]
Patch

This patch adds a new category and computer for attribute value proposals.It also takes care of Junit failures. I was not able to attach attribute.gif in patch, so you need to add this image manually. I copied this image from org.eclipse.wst.dtd.core plugin.
Comment 2 Nick Sandonato CLA 2010-08-09 17:06:08 EDT 
Created attachment 176195 [details]
patch

Rakesh, I propose that we merely simplify the proposal into a more natural default arrangement instead of providing a potentially more confusing category. Thank you for the patch, though.
Comment 3 Nick Sandonato CLA 2010-08-10 16:57:59 EDT 
Changes have been released.