Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320505 - [snaps] Snap binds to any host if SnapFactory is published prior to host ServletContext
Summary: [snaps] Snap binds to any host if SnapFactory is published prior to host Serv...
Status: CLOSED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: unknown (show other bugs)
Version: 2.1.0.M02-incubation   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Glyn Normington CLA
QA Contact:
URL: https://issuetracker.springsource.com...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-21 09:30 EDT by Dmitry Sklyut CLA
Modified: 2010-09-28 04:07 EDT (History)
2 users (show)

See Also:

Attachments
this is a test for the issue (5.83 KB, patch)
2010-07-21 09:49 EDT, Dmitry Sklyut CLA 		glyn.normington: iplog+
Details | Diff
This is a proposed fix (2.94 KB, patch)
2010-07-21 09:49 EDT, Dmitry Sklyut CLA 		glyn.normington: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Sklyut CLA 2010-07-21 09:30:22 EDT 
If SnapFactory is published prior to host servlet context, Snap will bind to any bundle that publishes servlet context prior to host servlet context.  That is, there is no validation/checking on Snap-Host attributes.
Comment 1 Dmitry Sklyut CLA 2010-07-21 09:49:22 EDT 
Created attachment 174850 [details]
this is a test for the issue
Comment 2 Dmitry Sklyut CLA 2010-07-21 09:49:45 EDT 
Created attachment 174851 [details]
This is a proposed fix
Comment 3 Dmitry Sklyut CLA 2010-07-21 09:51:30 EDT 
I wrote 100% of the code and have rights to contribute this code to Eclipse
Comment 4 Glyn Normington CLA 2010-07-21 11:57:56 EDT 
Thanks for the test and fix Dmitry. Committed in 40de9793325529b222e4091510796481a8bed77f.