Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320447 - [Compatibility] Selection in Outline view not picked up by Ctrl-Shift-G
Summary: [Compatibility] Selection in Outline view not picked up by Ctrl-Shift-G
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 1.0 RC3   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
: 320059 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-07-20 17:54 EDT by Boris Bokowski CLA
Modified: 2010-07-30 12:11 EDT (History)
2 users (show)

See Also:
pwebster: review+
bokowski: review+

Attachments
PageSite patch v1 (2.53 KB, patch)
2010-07-22 08:03 EDT, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Bokowski CLA 2010-07-20 17:54:18 EDT 
It looks like the selection coming from the Outline view, for purposes of Search References (Ctrl-Shift-G), is taken only from the first editor / pagebookview page.

1. Open two Java files, e.g. A.java and B.java
2. Open A.java and select a member of A in the Outline view. Hit Ctrl-Shift-G.
3. Open B.java and select a member of B in the Outline view. Hit Ctrl-Shift-G.

-> Search is performed on the member of A, not on the member of B.
Comment 1 Remy Suen CLA 2010-07-22 08:03:19 EDT 
Created attachment 174959 [details]
PageSite patch v1

Patch to create a localized IHandlerService for pages so that their handlers will activate/deactivate as needed when the page is shown/hidden.
Comment 2 Remy Suen CLA 2010-07-22 08:04:24 EDT 
(In reply to comment #1)
> Created an attachment (id=174959) [details]
> PageSite patch v1

Paul, please review the patch and perform a risk assessment.
Comment 3 Remy Suen CLA 2010-07-22 08:04:54 EDT 
Boris, please +1 for RC3 candidate consideration.
Comment 4 Paul Webster CLA 2010-07-22 11:15:30 EDT 
Looks good.
PW
Comment 5 Boris Bokowski CLA 2010-07-22 11:17:56 EDT 
+1.
Comment 6 Remy Suen CLA 2010-07-22 11:30:05 EDT 
Thanks, folks. Patch released to HEAD.
Comment 7 Remy Suen CLA 2010-07-27 12:36:53 EDT 
Verified with I20100726-2152 on Windows XP.
Comment 8 Remy Suen CLA 2010-07-30 12:11:50 EDT 
*** Bug 320059 has been marked as a duplicate of this bug. ***