Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320436 - jar's placed in Java EE 5 Ear's lib directory should never be considered "modules"
Summary: jar's placed in Java EE 5 Ear's lib directory should never be considered "mod...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0.5 P   Edit
Assignee: Hari Shankar CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 326015
  Show dependency tree
 
Reported: 2010-07-20 15:27 EDT by Hari Shankar CLA
Modified: 2010-09-22 17:54 EDT (History)
2 users (show)

See Also:
jsholl: review+
cbridgha: review+

Attachments
patch (11.52 KB, patch)
2010-07-20 15:28 EDT, Hari Shankar CLA 		no flags Details | Diff
updated patch (15.16 KB, patch)
2010-07-23 12:34 EDT, Hari Shankar CLA 		no flags Details | Diff
updated patch (15.35 KB, patch)
2010-07-28 14:53 EDT, Hari Shankar CLA 		ccc: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hari Shankar CLA 2010-07-20 15:27:19 EDT 
Build Identifier: 305P

When a jar dependency is added to the EAR in the Java EE Module Dependencies
page, a module entry is created in the application.xml, in addition to an entry
in the .component file. The entry in the application.xml should not be made if
the 'In Lib Dir' checkbox is checked.

This bug enhances bug 300098 with additional scenarios. The earlier bug covered fixing the module entry made in the application.xml. This bug covers navigator surfacing, refreshing and showing/hiding the jar in the 'Add/Remove Projects' dialog in the server view.

Reproducible: Always
Comment 1 Hari Shankar CLA 2010-07-20 15:28:45 EDT 
Created attachment 174783 [details]
patch
Comment 2 Hari Shankar CLA 2010-07-23 12:34:07 EDT 
Created attachment 175083 [details]
updated patch

Updated the patch to remove some cache optimizations that might have caused potential issues in future.
Comment 3 Chuck Bridgham CLA 2010-07-26 13:52:50 EDT 
approved
Comment 4 Carl Anderson CLA 2010-07-26 18:16:48 EDT 
The "updated patch" causes 54 JUnit failures in the org.eclipse.jst.server.core.tests.AllTests suite.  As such, I am reverting the code changes I committed for it in the R3_0_5_patches stream.
Comment 5 Hari Shankar CLA 2010-07-28 14:53:08 EDT 
Created attachment 175435 [details]
updated patch

In the previous patch, the value of JavaEEArchiveUtilities.getEARLibDir was not being checked for a null case, resulting in an incorrect value for the inLibDir variable, causing the server tools junits to fail.

Updated the patch, and ran all the server tooling and java ee tooling junits successfully.
Comment 6 Carl Anderson CLA 2010-08-05 13:31:26 EDT 
Committed to R3_0_5_patches
Comment 7 Carl Anderson CLA 2010-08-05 13:32:59 EDT 
Committed to R3_0_5_patches