This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 320429 - [releng] Sign the e4 build output
Summary: [releng] Sign the e4 build output
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.0 RC3   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-20 14:09 EDT by Paul Webster CLA
Modified: 2010-07-22 21:00 EDT (History)
3 users (show)

See Also:


Attachments
preliminary patch for testing (16.94 KB, patch)
2010-07-20 16:04 EDT, Kim Moir CLA
no flags Details | Diff
patch (12.78 KB, patch)
2010-07-21 10:06 EDT, Kim Moir CLA
no flags Details | Diff
patch (2.19 KB, patch)
2010-07-21 10:10 EDT, Kim Moir CLA
no flags Details | Diff
patch (14.49 KB, patch)
2010-07-21 16:12 EDT, Kim Moir CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-07-20 14:09:51 EDT
Our current e4 build output is not signed.

/shared/eclipse/e4/test.masterBuild.sh is the one that won't publish the e4 SDK to download.eclipse.org.

/releng/org.eclipse.e4.builder/builder/general/customTargets.xml is all of our build stuff.

postBuild target is where we do a little post-processing of our p2 repo and then start mirroring, create the product, and build the e4 SDK.  It could probably stand a little re-ordering, and the mirror can be disabled (or we clean it up later).

PW
Comment 1 Kim Moir CLA 2010-07-20 16:04:53 EDT
Created attachment 174787 [details]
preliminary patch for testing
Comment 2 Kim Moir CLA 2010-07-20 17:39:11 EDT
Ran a test build but the builder didn't reflect the changes on the filesystem on eclipse.org.  Not sure if this is because they were checked via pserver and the filesystem was out of sync.  In any case, I've reverted the changes and will run another test build tomorrow as Paul needs to run a real build in a bit.
Comment 3 Kim Moir CLA 2010-07-21 10:06:07 EDT
Created attachment 174854 [details]
patch
Comment 4 Kim Moir CLA 2010-07-21 10:10:58 EDT
Created attachment 174856 [details]
patch
Comment 5 Kim Moir CLA 2010-07-21 16:12:30 EDT
Created attachment 174910 [details]
patch
Comment 6 Kim Moir CLA 2010-07-21 16:55:46 EDT
The latest patch worked except for some reason I was prompted for the build password during the signing process.  Paul, I'll look at this tomorrow and have reverted the patches for your build tonight.
Comment 7 Kim Moir CLA 2010-07-22 10:43:26 EDT
Have fixed the ssh issue.  The I20100722-0955 test build was successfully signed. and packed.  The signing changes are released for your 11:30 build Paul.
Comment 8 Paul Webster CLA 2010-07-22 21:00:33 EDT
the composite repo didn't contain anything signed for the 11 am repo (because most of the bundles were the same).  So I've cleaned out the repo.


I20100722-1945 looks like it's signed and .../e4/updates/2010 installed signed bundles for me! :-)

PW