Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320417 - modulemap.xmi has no class
Summary: modulemap.xmi has no class
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.2.2   Edit
Assignee: Jason Sholl CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
: 343363 (view as bug list)
Depends on: 280151
Blocks: 321432
  Show dependency tree
 
Reported: 2010-07-20 12:17 EDT by Ed Willink CLA
Modified: 2011-04-20 11:36 EDT (History)
2 users (show)

See Also:
jsholl: pmc_approved? (david_williams)
jsholl: pmc_approved? (raghunathan.srinivasan)
jsholl: pmc_approved? (naci.dai)
deboer: pmc_approved+
jsholl: pmc_approved? (neil.hauge)
jsholl: pmc_approved? (kaloyan)
cbridgha: review+

Attachments
Patch for 3.2.2 (6.01 KB, patch)
2010-08-26 17:15 EDT, Jason Sholl CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2010-07-20 12:17:54 EDT 
The org.eclipse.jst.j2ee plugin provides a modulemap.xmi (with an unqualified URI) and an internal ModulemapPackage. This class is not part of the Helios distribution and so any EMF activity that loads the full registry is disrupted by an Exception. Some application code handles the exception correctly, but others don't causing strange application CNFE failures.

[Also import o.e.jst.j2ee with source has no source.]
Comment 1 Carl Anderson CLA 2010-07-20 13:44:59 EDT 
Assigning to Jason Sholl - this is additional clean up that should have happened with bug 280151.  The classes were deleted, but the entries in the plugin.xml still exist, referring to the deleted classes.
Comment 2 Ed Willink CLA 2010-07-20 14:12:49 EDT 
You probably need to fix some PDE preferences to ensure you get warnings.
Comment 3 Jason Sholl CLA 2010-08-26 17:15:18 EDT 
Created attachment 177567 [details]
Patch for 3.2.2
Comment 4 Chuck Bridgham CLA 2010-08-27 11:15:14 EDT 
approved
Comment 5 Jason Sholl CLA 2010-08-30 15:02:40 EDT 
    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

EMF model plugin.xml contributions that never should have been added to WTP.  These dead plugin.xml entries are causing problems for some users.

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 

No

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

JUnits

    * Give a brief technical overview. Who has reviewed this fix? 

Remove dead plugin.xml contributions.  Jason & Chuck.

    * What is the risk associated with this fix? 

None
Comment 6 Jason Sholl CLA 2010-08-30 17:23:55 EDT 
code checked into head for wtp 3.2.2 and 3.3
Comment 7 Carl Anderson CLA 2011-04-20 11:36:29 EDT 
*** Bug 343363 has been marked as a duplicate of this bug. ***