Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320372 - Memory Browser should invoke becomesVisible/becomesHidden on renderings
Summary: Memory Browser should invoke becomesVisible/becomesHidden on renderings
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-memory (show other bugs)
Version: 6.0.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 7.0.1   Edit
Assignee: Anton Leherbauer CLA
QA Contact: Ted Williams CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-20 06:26 EDT by Anton Leherbauer CLA
Modified: 2010-07-27 14:53 EDT (History)
1 user (show)

See Also:
john.cortell: review+

Attachments
Proposed fix (6.11 KB, patch)
2010-07-20 08:43 EDT, Anton Leherbauer CLA 		aleherb+eclipse: iplog-
Details | Diff
Reworked fix (7.29 KB, patch)
2010-07-20 10:24 EDT, Anton Leherbauer CLA 		aleherb+eclipse: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2010-07-20 06:26:25 EDT 
The MemoryBrowser currently disregards the IMemoryRendering API
- activated() / deactivated()
- becomesVisible() / becomesHidden()

Especially the second method pair is important because AbstractMemoryRendering implements those methods to connect/disconnect IExtendedMemoryBlocks to/from clients.
Comment 1 Anton Leherbauer CLA 2010-07-20 08:43:50 EDT 
Created attachment 174739 [details]
Proposed fix

This seems to do it.  There is currently no differentiation between active and visible, but I don't see a good reason to make that distinction for the Memory Browser.
I also re-added the public ID constant which got removed in 1.21.
Comment 2 Anton Leherbauer CLA 2010-07-20 10:24:28 EDT 
Created attachment 174751 [details]
Reworked fix

I reworked the fix such that renderings for multiple memory spaces are also considered.
Comment 3 CDT Genie CLA 2010-07-21 06:23:03 EDT 
*** cdt cvs genie on behalf of aleherbau ***
Bug 320372 - Memory Browser should invoke becomesVisible/becomesHidden on renderings
Also re-adds public constant MemoryBrowser.ID which got removed in version 1.21

[*] MemoryBrowser.java 1.5.2.4.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/memory/org.eclipse.cdt.debug.ui.memory.memorybrowser/src/org/eclipse/cdt/debug/ui/memory/memorybrowser/MemoryBrowser.java?root=Tools_Project&r1=1.5.2.4.2.1&r2=1.5.2.4.2.2
Comment 4 CDT Genie CLA 2010-07-21 08:23:04 EDT 
*** cdt cvs genie on behalf of aleherbau ***
Bug 320372 - Memory Browser should invoke becomesVisible/becomesHidden on renderings
Also re-adds public constant MemoryBrowser.ID which got removed in version 1.21

[*] MemoryBrowser.java 1.29.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/memory/org.eclipse.cdt.debug.ui.memory.memorybrowser/src/org/eclipse/cdt/debug/ui/memory/memorybrowser/MemoryBrowser.java?root=Tools_Project&r1=1.29.2.1&r2=1.29.2.2
Comment 5 Anton Leherbauer CLA 2010-07-21 08:27:59 EDT 
Committed the fix to HEAD, cdt_7_0 and cdt_6_0_2_special.
John, please review.
Comment 6 CDT Genie CLA 2010-07-21 09:23:04 EDT 
*** cdt cvs genie on behalf of aleherbau ***
Bug 320372 - Memory Browser should invoke becomesVisible/becomesHidden on renderings
Also re-adds public constant MemoryBrowser.ID which got removed in version 1.21

[*] MemoryBrowser.java 1.32 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/memory/org.eclipse.cdt.debug.ui.memory.memorybrowser/src/org/eclipse/cdt/debug/ui/memory/memorybrowser/MemoryBrowser.java?root=Tools_Project&r1=1.31&r2=1.32
Comment 7 John Cortell CLA 2010-07-27 14:53:00 EDT 
Looks good to me.