Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320341 - Drag and drop rectangles: DnDManager should use stippled tracker
Summary: Drag and drop rectangles: DnDManager should use stippled tracker
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.0 RC3   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-19 19:52 EDT by Stefan Mücke CLA
Modified: 2010-07-27 14:57 EDT (History)
3 users (show)

See Also:
susan: review? (emoffatt)
bokowski: review+

Attachments
patch (917 bytes, patch)
2010-07-20 19:12 EDT, Susan McCourt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Mücke CLA 2010-07-19 19:52:24 EDT 
I think the line width of the DND preview rectangles is too thin.

e4 should use the same preview rectangles as 3.x by setting the 'stippled' option on the tracker:

tracker.setStippled(true);

BTW, I think the DnD... classes in e4 should be renamed DND... to be consistent with SWT.
Comment 1 Boris Bokowski CLA 2010-07-20 17:58:20 EDT 
I have no opinion on this one. It'd be pretty safe if we did it, and 3.6 uses setStippled(true). Susan?
Comment 2 Susan McCourt CLA 2010-07-20 19:11:47 EDT 
I see no reason to change from 3.6.  Users are used to the stippled look and this seems a safe change.
Comment 3 Susan McCourt CLA 2010-07-20 19:12:25 EDT 
Created attachment 174804 [details]
patch

patch that sets the stippling.
Comment 4 Susan McCourt CLA 2010-07-20 19:12:57 EDT 
Eric, can you review?
Comment 5 Susan McCourt CLA 2010-07-20 19:13:55 EDT 
Boris, OK for RC3?

Stefan, can you open a separate bug for the naming inconsistency?
I'm sure we'll do an API cleanup sweep in 4.1 and we could address this then.
Comment 6 Boris Bokowski CLA 2010-07-20 20:25:53 EDT 
sure
Comment 7 Stefan Mücke CLA 2010-07-21 01:10:03 EDT 
(In reply to comment #5)
> Stefan, can you open a separate bug for the naming inconsistency?
> I'm sure we'll do an API cleanup sweep in 4.1 and we could address this then.

Opened bug 320460. Target milestone needs to be set to 4.1.
Comment 8 Susan McCourt CLA 2010-07-22 11:40:47 EDT 
these changes went in with bug 302758.
stippling is present in  I20100721-2056
Comment 9 Susan McCourt CLA 2010-07-27 13:51:09 EDT 
verified (again) on Win7, Build id: I20100726-2152
Comment 10 Eric Moffatt CLA 2010-07-27 14:57:20 EDT 
Verified on XP in I20100726-2152.