Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320333 - GMF Notation builds fail due to missing JUnit tests
Summary: GMF Notation builds fail due to missing JUnit tests
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: Notation (show other bugs)
Version: 2.1   Edit
Hardware: PC Linux
: P3 normal
Target Milestone: ---   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-19 17:46 EDT by Anthony Hunter CLA
Modified: 2020-02-20 11:30 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Hunter CLA 2010-07-19 17:46:10 EDT
The current common modeling framework assumes you have JUnit tests to run. This means every build breaks for GMF Notation.

You can run a GMF Notation build manually and turn off "Run Tests" from the build page to get a successful build.
Comment 1 Anthony Hunter CLA 2010-08-12 16:04:56 EDT
In addition, the logging for the JUnits need to be fixed. If you use the wrong JRE or Eclipse, tests also fail,and you get no errors indicating why.

An additional example:
     [exec] Start Xvfb on :15
     [exec] xhost:  unable to open display "localhost:15.0"
Since Xvfb is broken, the tests should not even start.
Comment 2 Anthony Hunter CLA 2010-10-04 10:56:05 EDT
I added the org.eclipse.gmf.tests.runtime.notation and org.eclipse.gmf.tests.runtime.notation-feature to HEAD. I created a simple NotationTest that creates a notational metamodel and opens it in a text editor. This test ensures we are running a UI test like the GMF Runtime. After a few tweaks the build completes successfully. http://modeling.eclipse.org/modeling/gmp/downloads/index.php?showAll=1&hlbuild=N201009301044&sortBy=date&project=gmf-notation#N201009301044

There are now two things remaining to complete:

- push the changes back to R1_4_maintenance
- fix the build scripts to not include the org.eclipse.test warnings. These are the 19W in the 1.5.0 build.
Comment 3 Anthony Hunter CLA 2010-12-16 11:56:37 EST
I have done no further work on this enhancement since October. An update:

Looks like we do not need to run any more 1.4.x maintenance builds so I will not push the changes back to R1_4_maintenance. so moving this Bugzilla to 1.5.0 and normal.

I still want to look into the 19W in the org.eclipse.test bundle.
Comment 4 Pierre-Charles David CLA 2020-02-20 11:30:35 EST
There are (3) tests in org.eclipse.gmf.tests.runtime.notation.NotationTest and they are properly run during the build, see https://ci.eclipse.org/gmf-runtime/job/gmf-notation-master/.