Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320239 - View Toolbar Icons are clipped
Summary: View Toolbar Icons are clipped
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: 1.0 RC3   Edit
Assignee: Bogdan Gheorghe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-19 06:20 EDT by Thomas Schindl CLA
Modified: 2010-07-23 11:43 EDT (History)
4 users (show)

See Also:
bokowski: review+

Attachments
Screenshot (6.36 KB, image/png)
2010-07-19 06:20 EDT, Thomas Schindl CLA 		no flags Details
Patch (1.76 KB, patch)
2010-07-22 14:50 EDT, Bogdan Gheorghe CLA 		no flags Details | Diff
Update to patch (1.96 KB, patch)
2010-07-22 16:08 EDT, Bogdan Gheorghe CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2010-07-19 06:20:39 EDT 
Created attachment 174603 [details]
Screenshot

I only see this issue on GTK.
Comment 1 Thomas Schindl CLA 2010-07-19 06:21:21 EDT 
Paul is this only on my Ubuntu Box or a do you also see this?
Comment 2 Thomas Schindl CLA 2010-07-19 06:34:18 EDT 
if it turns out to be a common GTK problem i think we should fix it before we ship because it makes 4.0 look strange.
Comment 3 Paul Webster CLA 2010-07-19 09:15:49 EDT 
I don't see them clipped, just bug 319780
PW
Comment 4 Thomas Schindl CLA 2010-07-20 02:16:01 EDT 
This happens for me on Ubuntu
Comment 5 Bogdan Gheorghe CLA 2010-07-20 11:13:56 EDT 
The differences you guys see comes from the default themes used on GTK - RHEL5 uses Clearlooks while the latest Ubuntu uses the Ambiance theme. The Ambiance theme adds a bunch of padding to tool items, hence the clipping.

We need to figure out and set the tab height before we set a top right control (3.6 did this which is why it doesn't have the same problem). I will attach a patch.
Comment 6 Boris Bokowski CLA 2010-07-20 16:44:40 EDT 
We've listed this as a P2 on our RC3 list.
Comment 7 Bogdan Gheorghe CLA 2010-07-22 14:50:46 EDT 
Created attachment 175011 [details]
Patch
Comment 8 Bogdan Gheorghe CLA 2010-07-22 16:08:29 EDT 
Created attachment 175020 [details]
Update to patch
Comment 9 Bogdan Gheorghe CLA 2010-07-22 16:10:02 EDT 
This patch updates the tab height based on the size of the top right control being set in the CTabFolder as well as adding some missing clean up code for disposing of the background image/color when a new top right control is set.
Comment 10 Boris Bokowski CLA 2010-07-22 17:23:39 EDT 
+1
Comment 11 Bogdan Gheorghe CLA 2010-07-23 11:43:09 EDT 
Fixed in HEAD > 20100722