Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320217 - [Hibernate] HibernateStoreAccessor grabs all query languages but throws exceptions for unhandled ones
Summary: [Hibernate] HibernateStoreAccessor grabs all query languages but throws excep...
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eike Stepper CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-19 02:59 EDT by Eike Stepper CLA
Modified: 2019-11-08 03:15 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Stepper CLA 2010-07-19 02:59:13 EDT 
HibernateStoreAccessor is an IQueryHandlerProvider and it should only provide IQueryHandlers for the given CDOQueryInfo that can handle this query. Currently it always returns the HibernateQueryHAndler but that one throws an exception if the query language is not "hql". That prevents users from contributing their own query handlers to the repository.
Comment 1 Eike Stepper CLA 2010-07-19 03:02:05 EDT 
I moved the language comparison logic from HibernateQueryHandler to HibernateStoreAccessor.

Further I changed the String.equalsIgnoreCase() to the new StringUtil.equalsUpperOrLowerCase() in both HibernateStoreAccessor and DBStoreAccessor.
Comment 2 Eike Stepper CLA 2010-07-19 03:03:11 EDT 
Committed to HEAD
Comment 3 Eike Stepper CLA 2011-06-23 03:37:06 EDT 
Available in R20110608-1407