Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320199 - [preferences] UserLibraryPreferencePage Edit/Remove do not work as expected when same jar is contained in 2 or more libs
Summary: [preferences] UserLibraryPreferencePage Edit/Remove do not work as expected w...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M1   Edit
Assignee: Raksha Vasisht CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-18 15:09 EDT by Raksha Vasisht CLA
Modified: 2010-08-03 14:14 EDT (History)
3 users (show)

See Also:

Attachments
Patch (3.29 KB, patch)
2010-07-18 15:09 EDT, Raksha Vasisht CLA 		daniel_megert: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raksha Vasisht CLA 2010-07-18 15:09:17 EDT 
Created attachment 174583 [details]
Patch

I20100713-0800

Steps :

1) Go to UserLibraryPreferencePage, add a new lib and a jar under it (A -> x.jar)
2) Add another lib and same jar (B -> x.jar)
3) Edit one of the attributes in the second jar B -> x.jar
=> The value shows up in A-> x.jar . Same problem with Remove as well.



Attaching a patch.
We should refresh the parent container always since that uniquely identifies the list elements and the attributes and refreshes the appropriate element and not the first occurrence of the element in the tree.
Comment 1 Dani Megert CLA 2010-07-19 10:40:57 EDT 
Patch looks good!
Comment 2 Raksha Vasisht CLA 2010-07-21 02:32:29 EDT 
Committed to HEAD.
Comment 3 Deepak Azad CLA 2010-08-03 14:14:41 EDT 
Verified with I20100802-1800 on Ubuntu.