Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320140 - Removing attributes or methods from diagram doesn't work as expected
Summary: Removing attributes or methods from diagram doesn't work as expected
Status: RESOLVED FIXED
Alias: None
Product: Tigerstripe
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 0.5M0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-16 15:36 EDT by Navid Mehregani CLA
Modified: 2010-10-27 19:20 EDT (History)
1 user (show)

See Also:


Attachments
patch_320140.txt (10.81 KB, patch)
2010-10-26 17:14 EDT, Daniel Johnson CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Navid Mehregani CLA 2010-07-16 15:36:37 EDT
Build Identifier: 

In a class diagram > Add an Entity > Add four attributes > Select the second, third, and fourth attributes > Right click > Remove from Model.  Notice that the fourth attribute remains.

The same problem exists with methods

Reproducible: Always
Comment 1 Chris Hartley CLA 2010-07-19 04:03:47 EDT
I tried this with Enum literals and the third and fourth literals remain !
Comment 2 Navid Mehregani CLA 2010-10-25 13:35:43 EDT
I'm no longer able to reproduce this issue in the diagrams.  Removing methods/attributes works as expected.  HOWEVER, doing this from TS Explorer doesn't work as expected.  Try the following:

Create a new entity with four attributes and four methods > Expand the entity in TS Explorer > Select all attributes/methods > Right click > select delete > Yes.  Notice that attributes/methods are not removed as expected.  Some are removed, but most of them remain.
Comment 3 Daniel Johnson CLA 2010-10-26 17:14:13 EDT
Created attachment 181784 [details]
patch_320140.txt

Artifacts were being edited once for each method/literal removed, but none of the changes were saved back to the artifact manager until after all were complete, so only the last change would be saved back. Now keeping track of what artifacts have been edited using a map, and if the artifact comes up again will grab it out of the map and edit it further, and still just doing one save back the artifact manager at the end.
Class Changed: TSDeleteAction
Comment 4 Navid Mehregani CLA 2010-10-27 19:20:53 EDT
Thanks Dan! Patch was reviewed and submitted.  Your changes made sense.  I guess this was only tested with a single selection in the past.