Community
Participate
Working Groups
JSPComment may inherit directly from Node, as Comment. JavaScript does not need to inherit from CharacterDataElement. -> CharacterDataElement should be deleted. The JSP discoverers and generator should be modified in consequence.
Hi Fabien, Please find attached the corresponding modification, those impact the following projects : org.eclipse.gmt.modisco.jee.jsp org.eclipse.gmt.modisco.jee.jsp.discoverer org.eclipse.gmt.modisco.jee.jsp.discoverer.tests org.eclipse.gmt.modisco.jee.jsp.generation org.eclipse.gmt.modisco.jee.jsp.generation.tests Even if we are dealing with a minor modification in the Ecore, this results in quite a big patch because of the regeneration of the Metamodel implementation as well as the regeneration of the MoDisco JSP Lexer/Parser 1. I, Nicolas Guyomar, and others contributors listed in this bug, authored 100% of the content 2. I have the rights to donate the content to Eclipse under the EPL 3. I have already provided the filled Employer Consent Forms to the Foundation Regards Nicolas
Created attachment 174493 [details] Removes CharacterDataElement from MoDisco JSP Meta Model
Frederic, here is a contribution from an employee of Mia-Software. The company has signed a Member Commiter Agreement. It is possible to commit this work without the need of a CQ, with the confirmation that this work is done under PMC supervision. Is it possible for you, or someone else of modeling PMC, to approve this work ? Such a contribution deals with Java technologies reverse engineering. This theme was planned in MoDisco roadmap ("Theme and priorities" of MoDisco project plan). Thanks in advance.
Kenn, here is a contribution from an employee of Mia-Software. The company has signed a Member Commiter Agreement. It is possible to commit this work without the need of a CQ (as Sharon confirmed it in older CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=3846#c9), with the confirmation that this work is done under PMC supervision. Is it possible for you, or someone else of modeling PMC, to approve this work ? Such a contribution deals with Java/JEE technologies reverse engineering. This theme was planned in MoDisco roadmap ("Theme and priorities" of MoDisco project plan). I will describe more precisely the proposed enhancement if you wish. Thanks in advance.
Thanks for your contribution Nicolas, thanks for your quick approval Kenn. The code has been commited into SVN.
The patch has been successfully applied.
