Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320096 - Closing a detached stack or view fails
Summary: Closing a detached stack or view fails
Status: CLOSED DUPLICATE of bug 320097
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-16 08:32 EDT by Stefan Mücke CLA
Modified: 2011-04-14 10:07 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Mücke CLA 2010-07-16 08:32:50 EDT 
1. Start a fresh e4 workbench
2. Detach the Javadoc view by dragging it off the workbench window
3. Close the detached stack

Result: Error dialog for the following exception:

!ENTRY org.eclipse.e4.ui.workbench 4 0 2010-07-16 14:29:17.792
!MESSAGE Internal Error
!STACK 0
org.eclipse.swt.SWTException: Widget is disposed
  at org.eclipse.swt.SWT.error(SWT.java:4083)
  at org.eclipse.swt.SWT.error(SWT.java:3998)
  at org.eclipse.swt.SWT.error(SWT.java:3969)
  at org.eclipse.swt.widgets.Widget.error(Widget.java:468)
  at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:340)
  at org.eclipse.e4.ui.widgets.CTabItem.isShowing(CTabItem.java:261)
  at org.eclipse.e4.ui.widgets.CTabFolder$3.getLocation(CTabFolder.java:1106)
  ...
  at org.eclipse.swt.widgets.Control.setSavedFocus(Control.java:3269)
  at org.eclipse.swt.widgets.Decorations.restoreFocus(Decorations.java:821)
  at org.eclipse.swt.widgets.Decorations.WM_ACTIVATE(Decorations.java:1639)
  at org.eclipse.swt.widgets.Shell.WM_ACTIVATE(Shell.java:2114)
  ...
Comment 1 Eric Moffatt CLA 2010-07-16 09:03:10 EDT 
I suspect that this is (will be) fixed in the next build. This was the result of the new CTF code that moves stack's toolbars down to the next line if there's not enough space on the top line.

Please retry with today's build and ping back if there is still an issue.
Comment 2 Stefan Mücke CLA 2010-07-16 09:05:38 EDT 
I currently get this bug with CVS HEAD.
Comment 3 Eric Moffatt CLA 2010-07-16 09:25:24 EDT 
Did you use the red 'x' to close or did you close the view ? There are different issues depending on the path.

Btw, I've just checked a fix to some bogus code in the PartRenderingEngine as regards DW's. With this change the scenario seems to work for me if I close the view, not the shell.

I'm looking into how to 'wire off' the close button now...
Comment 4 Stefan Mücke CLA 2010-07-16 09:29:56 EDT 
I used the button of the surrounding window (i.e. the Microsoft Windows button, not the button on the tab item).
Comment 5 Eric Moffatt CLA 2010-07-16 11:11:02 EDT 
Stefan, first off thanks *huge* for doing this, you've already caught a number of regressions !!

If you synch up you should find that the red 'x' is gone from DW's now...could you retest and close this (as a DUP of 320097) if it's working now?
Comment 6 Eric Moffatt CLA 2011-04-14 10:07:07 EDT 

*** This bug has been marked as a duplicate of bug 320097 ***