Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 320005 - [launcher] --launcher.XXMaxPermSize: isSunVM should return true for Oracle
Summary: [launcher] --launcher.XXMaxPermSize: isSunVM should return true for Oracle
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows All
: P3 normal (vote)
Target Milestone: 3.6.1   Edit
Assignee: Andrew Niefer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 320792 (view as bug list)
Depends on:
Blocks: 319514 320006
  Show dependency tree
 
Reported: 2010-07-15 11:47 EDT by Andrew Niefer CLA
Modified: 2010-07-24 05:37 EDT (History)
9 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2010-07-15 11:47:15 EDT
The --launcher.XXMaxPermSize argument applies a vm argument -XX:MaxPermSize conditionally on the vm being from Sun.

On windows, the company name from the jvm's exe/dll is checked.  We should now set the vm argument for  "Oracle" as well as "Sun Microsystems".

*nix platforms are not affected as there sun vms are detected by execing "java -version" and looking for "Java HotSpot(TM)" or "OpenJDK"
Comment 1 Andrew Niefer CLA 2010-07-15 11:48:40 EDT
See patch and +1 from Tom on bug 319514.
Comment 2 Andrew Niefer CLA 2010-07-15 12:28:40 EDT
Fixed in the 3.6.x branch
Comment 3 Andrew Niefer CLA 2010-07-15 13:30:56 EDT
I have tagged this as "R36x_v20100715" for Helios SR1.

The following projects have changed:
org.eclipse.equinox.executable
org.eclipse.equinox.launcher.win32.win32.x86_64
org.eclipse.equinox.launcher.win32.win32.ia64
org.eclipse.equinox.launcher.win32.win32.x86
org.eclipse.equinox.launcher.wpf.win32.x86
Comment 4 Konstantin Komissarchik CLA 2010-07-15 15:45:30 EDT
Andrew,

We are seeing evidence that JRockit does not always happily continue after a warning on -XX:MaxPermSize. The issue seems to be specific to some versions of Windows and possibly versions of JRockit. The one that didn't start for us is Win 7 64-bit.

Raj, could you list configurations tested, including JRockit version on each?

Perhaps it would make sense to port the *nix launcher logic to Windows? That approach seems more robust.
Comment 5 Konstantin Komissarchik CLA 2010-07-15 15:46:18 EDT
Forgot to add... We will help with testing of modified launcher.
Comment 6 Ram Venkataswamy CLA 2010-07-15 16:26:54 EDT
JRockit Update:

After a bit of investigation we found out the JRockit issue updated earlier was caused by using 32 bit vm instance on 64 bit OS. I am able to launch the IDE with 64 bit JRockit instance. 

NOTE: I still see the warning “[WARN ][jrockit] MaxPermSize=512m ignored: Not a valid option for JRockit” but that doesn’t stop from using the product.
Comment 7 Konstantin Komissarchik CLA 2010-07-15 16:32:23 EDT
> After a bit of investigation we found out the JRockit issue updated earlier was
> caused by using 32 bit vm instance on 64 bit OS. I am able to launch the IDE
> with 64 bit JRockit instance. 

Ram,

Could you confirm that the case that fails was trying to use 64-bit Eclipse on 32-bit JRockit? The 32-bit Eclipse with 32-bit JRockit on 64-bit Windows case is expected to work...
Comment 8 Andrew Niefer CLA 2010-07-15 16:40:50 EDT
It would be unfortunate if we had to port the *nix code over to windows as that is a larger code change than we generally like to make in a maintenance release.

Execing "java -version" is a bigger hit to startup times.  Checking the output of "java -version" would distinguish between hotspot and jrockit, but it still suffers from the problem of a string change breaking us.  

Is "Java HotSpot(TM)" that much more permanent than "Sun Microsystems" was?  (I guess maybe it is...)
Comment 9 Ram Venkataswamy CLA 2010-07-15 16:44:16 EDT
Yes, the earlier failure was caused trying to use 32 bit JRockit for 64 bit Eclipse. The 32 bit Eclipse with 32-bit JRockit on 64 bit Windows works fine.
Comment 10 Konstantin Komissarchik CLA 2010-07-15 16:46:53 EDT
> Is "Java HotSpot(TM)" that much more permanent than "Sun Microsystems" was?  
> (I guess maybe it is...)

Probably a bit more permanent than company name. In the acquisitions that I've been through, the company name was not kept in products, but the names of the technologies stayed...

BEA WebLogic -> Oracle WebLogic
Sun Java HotSpot -> Oracle Java HotSpot

For what it's worth.
Comment 11 Remy Suen CLA 2010-07-24 05:37:53 EDT
*** Bug 320792 has been marked as a duplicate of this bug. ***