Community
Participate
Working Groups
Build Identifier: 20100617-1415 When JSP comments are used inside the HTML SCRIPT element and the leading tag of the comment ("<%--") happens to be deleted and then added in again in the process of the editing, the editor adds a pair of hyphens in front of the end tag of the SCRIPT tag (--</scipt>). The user might not be aware of this addition when the content of the SCRIPT element is long. The leading hyphens usually result in loss of functionality on the page, probably because the end tag of script is not recognised any more by at least some browsers. For example a button that does not work any more. Reproducible: Always Steps to Reproduce: 1. Create a new JSP page using Eclipse (new -> JSP File) 2. Add a SCRIPT element under the HEAD element under the TITLE element 3. Enter a JSP comment (<%-- --%>) in side the SCRIPT element. 4. Delete the start tag of the comment 5. Type the strat tag of the comment in again 6. Observe that the editor adds two hyphens in front of the end tag of the SCRIPT element
I found a similar but slightly different case, which I think is caused by the same bug and may be helpful to understand its behaviour better. Consider the following scenario: (1) Create a JSP file as before and open it in the JSP Editor. (2) Add a SCRIPT element. (3) Add the following code: t = ""; if (t.length > 0 { alert("hello"); } (4) Add a JSP comment above the code so that the content of the SCRIPT element becomes: <%-- // Comment. --%> t = ""; if (t.length > 0 { alert("hello"); } (5) Save (6) Observe the appearance of red zig-zag underlining (usually under the zero). Of course there is nothing wrong and the syntax checker should not underline anything. It seems it find a problem with the ">" comparator in the code but only once the comment has been added. Best regards, Johannes
(In reply to comment #1) > I found a similar but slightly different case, which I think is caused by the > same bug and may be helpful to understand its behaviour better. Consider the > following scenario: > (1) Create a JSP file as before and open it in the JSP Editor. > (2) Add a SCRIPT element. > (3) Add the following code: > t = ""; > if (t.length > 0 { > alert("hello"); > } > (4) Add a JSP comment above the code so that the content of the SCRIPT element > becomes: > <%-- > > // Comment. --%> > t = ""; > if (t.length > 0 { > alert("hello"); > } > (5) Save > (6) Observe the appearance of red zig-zag underlining (usually under the zero). > > Of course there is nothing wrong and the syntax checker should not underline > anything. It seems it find a problem with the ">" comparator in the code but > only once the comment has been added. > > Best regards, Johannes The syntax error is correct. You don't have the closing ) after the 0. The first problem I can reproduce, but I don't think its a JSDT problem.
Created attachment 179093 [details] Add smart insertion for jsp comments inside jsp scriptlets only Added the check to insert auto completion of jsp comment syntax inside scriptlets ony.Currently it was adding "--" even if the parent node is is naything oter than scriptlet, like <script>
Thanks, Sarika. I've checked in the changes to HEAD, but we'll have to wait until 3.2.3 opens up.
Code checked in to 3_2_Maintenance.
*** Bug 338806 has been marked as a duplicate of this bug. ***
