Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319986 - CA pop-up unreadable: background from system but not foreground
Summary: CA pop-up unreadable: background from system but not foreground
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P1 normal with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 321703
Blocks:
  Show dependency tree
 
Reported: 2010-07-15 09:49 EDT by Rik Bartolini CLA
Modified: 2020-05-14 11:08 EDT (History)
2 users (show)

See Also:


Attachments
Screenshot (53.62 KB, image/png)
2010-07-22 06:50 EDT, Hans Duedal CLA
no flags Details
patch for dltk (2.67 KB, patch)
2010-07-22 10:18 EDT, Zhongwei Zhao CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rik Bartolini CLA 2010-07-15 09:49:21 EDT
Build Identifier: 20100218-1602

Ubuntu 10.04 with default theme Ambiance make code assiste pop-up enreadable because of black on black.
This happen mainly on PDT (completely black pop-up) but in part also with WTP (e.g. am html tag) where info is white on black but "Press F2 for focus" remain black.

This happen because tooltips background color is taken from the system while the foreground is static.

The system color I'm speaking about are those that can be seen on System->preferences-appearance-><any theme>->colors-Tooltips

Reproducible: Always
Comment 1 Zhongwei Zhao CLA 2010-07-15 21:09:39 EDT
System->preferences-appearance-><any theme>->colors-Tooltips?

I use helios,and I could not find tooltips,now we only maintain pdt2.2,so can you try pdt2.2?
Comment 2 Rik Bartolini CLA 2010-07-16 03:54:52 EDT
System->preferences-appearance-><any theme>->colors->Tooltips
is on Ubuntu, not Eclipse.
Is where you change system colors. And Eclipse use them but only partially, and this is the problem. So anyone using the new Ubuntu 10.04 with default theme, don't see any code assiste pop-up (those ho show phpdoc, usually in yellow background with black foreground)

That is, Eclipse (and PDT too, but the problem is partually also in WTP), pick colors from the system, 
BUT (and here is the problem),
if you have a theme (like Ubuntu 10.04 default: Ambiance) that has tooltips foreground=white and background=black, SINCE ECLIPSE ONLY GET the variable system tooltips BACKGROUND BUT NOT system tooltips FOREGROUND, we end up with Eclipse having code assist pop-up black on black.

And this happen not on the first pop-up, but from the 2nd occurrence.

So installing Ubuntu, installing eclipse PDT, you have immediatly this behaviour:
the first pop-up is yellow background and black foreground. The 2nd pop-up is black on black.


I'm gonna try the new version.

In the meantime, can you tell me if there is a place in eclipse preferences to force the color of the phpdoc pop-up? So if this problem is in the new version I can change the foreground manually as a workaround.
Comment 3 Rik Bartolini CLA 2010-07-16 07:18:32 EDT
New version 2.2.0 installed. Same problem.

PS: Now I have also other problems :-( like code sense laking many elements.
E.g. with 2.1 typing checkdnsrr will show parameters. And with CTRL it jumped to the source. Now checkdnsrr is unknown.
I'll try with the latest update.
Comment 4 Rik Bartolini CLA 2010-07-16 07:49:57 EDT
Wait wait wait! Now the problem is 1/2 solved.

With the 2.2, now the hover works (when I put the mouse on a function), but still have problem when the same thing happen choosing from the list that code completion show.

So if I now type
str
the code completion open the window with the list of metod/attributes, and on the right of this window there is another window: the phpdoc info.
This 2nd window is black.

Despite the window is the same if evoked from hovering over keyword or by the code completion, in this 2nd case is still black as in 2.1.

So half problem solved.
Comment 5 Roy Ganor CLA 2010-07-16 11:17:29 EDT
seems like we can help with this content assist info box,
Comment 6 Hans Duedal CLA 2010-07-22 06:50:03 EDT
Created attachment 174957 [details]
Screenshot

screenshot of the CA popup when using the new default theme for Ubuntu
Comment 7 Zhongwei Zhao CLA 2010-07-22 10:18:20 EDT
Created attachment 174981 [details]
patch for dltk
Comment 8 Zhongwei Zhao CLA 2010-08-05 03:29:15 EDT
depend on bug 321703
Comment 9 Roy Ganor CLA 2010-08-05 04:50:49 EDT
applied to branch as well
Comment 10 Petyo Tanchev CLA 2010-09-01 07:44:16 EDT
Tested on 2.2.1.v20100829
Fixed
Comment 11 Rik Bartolini CLA 2010-12-13 06:07:28 EST
I still have the problem with 2.2.1.v20101001-2300

org.eclipse.php (2.2.1.v20101001-2300-7L7J1F8NcJTJTJJT9cmJJ) "PDT Plug-in"

Maybe dltk is not ok?
org.eclipse.dltk.core (2.0.0.v20100518-1923-7L-0EAAoOVMSUaEAZ8w_)