Community
Participate
Working Groups
We should investigate if the toolbar separator can be styled (different color?) or if we need to adjust the toolbar background color. Alternatively, we could use an image instead of the OS-drawn separator.
Oleg or Remy, could one of you please attach a screenshot of Eclipse 4.0 (blue theme) on Windows XP? Thanks!
Created attachment 174384 [details] Screenshot depicting the problem in question. (In reply to comment #1) > Oleg or Remy, could one of you please attach a screenshot of Eclipse 4.0 (blue > theme) on Windows XP? Thanks! See attached.
Forgot to say that comment 2 is from I20100714-2048.
Linda caught this in a review last week (that I'm just catching up with) - she had flagged it as "separators are missing on XP" so she didn't realize it was a color problem. The mockups used the coolbar separators and so they were visible. I noticed in the mockups there is an (accidental) 3-d looking separator alongside the other coolbar separators. With the lighter line next to the dark line, it's more visible. Is there an OS-style we could change?
(In reply to comment #4) > I noticed in the mockups there is an (accidental) 3-d looking separator > alongside the other coolbar separators. With the lighter line next to the dark > line, it's more visible. Is there an OS-style we could change? Was this a question for Bogdan?
Created attachment 174457 [details] screenshot on win7 - workbench using win xp blue stylesheet I'm assuming this is a platform-specific problem that depends on how the separator is rendered on the user's platform. On Win7, a 3-D separator is used, so that even on the win xp blue theme, the separators are visible. (They don't "pop," but they are acceptable I think). So the question is how to style a ToolItem of style SWT.SEPARATOR??
Created attachment 174458 [details] blind patch attempt at a patch - adds a CSS ID to all of the tool item separators created by the SeparatorRenderer and ToolBarRenderer. Sets a color for the separator in the win xp blue style sheet (to be attached separately). I don't see any effect, but if win7 separators are always 3D, the color may simply be ignored. Needs to be tried on win XP.
Created attachment 174459 [details] CSS from org.eclipse.platform CSS. Also, do we know if WinXp Olive is hard to see separators on WinXP?
this patch is really me guessing what to do. - I'm not sure if ToolItems work the same as do actual controls with respect to the CSS Engine. This patch assumes they do. - I'm not sure I've chosen a good color. We could go either extra dark, or we could go white/very light blue. Would have to try both and compare. This patch does extra dark gray. - I'm not sure the foreground color is the right color to set on a tool separator assuming the rest of my assumptions are correct.
my "guesswork" patch didn't work, the OS won't let you set color on a separator. We had a brief chat with Linda and the direction going forward is to see if we can lighten up the toolbar gradient enough to see the separator. We want to avoid drawing our own separators if possible. Bogdan's going to experiment and get Linda's feedback.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
This is a mass change to close all e4 bugs marked with "stalebug" whiteboard. If this bug is still valid, please reopen and remove the "stalebug" keyword.
