Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319883 - Refactoring: Add Use Statement to Module
Summary: Refactoring: Add Use Statement to Module
Status: CLOSED DUPLICATE of bug 321790
Alias: None
Product: PTP
Classification: Tools
Component: Photran.Refactoring Engine (show other bugs)
Version: 6.0   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 7.0   Edit
Assignee: Matthew Fotzler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 321790
  Show dependency tree
 
Reported: 2010-07-14 12:48 EDT by Matthew Fotzler CLA
Modified: 2010-09-24 15:12 EDT (History)
2 users (show)

See Also:


Attachments
refactoring and test suite patch (47.97 KB, patch)
2010-07-14 12:48 EDT, Matthew Fotzler CLA
no flags Details | Diff
Revised patch - renamed, merged with other changes (41.34 KB, patch)
2010-09-21 11:53 EDT, Jeffrey Overbey CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Fotzler CLA 2010-07-14 12:48:41 EDT
Created attachment 174315 [details]
refactoring and test suite patch

This refactoring adds a use only statement to the target module M' if it doesn't already exist, giving access to the entities in E from module M.
Comment 1 Jeffrey Overbey CLA 2010-07-14 13:55:58 EDT
Thanks.  Matt and Ashley, can you *both* please confirm that

1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others,

2. you have the right to contribute the code to Eclipse, and

3. you have included the EPL license header in all source files?
Comment 2 Matthew Fotzler CLA 2010-07-14 14:54:53 EDT
Yes, I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, I have the right to contribute the code to Eclipse, and I have included the EPL license header in all source files.
Comment 3 Ashley Kasza CLA 2010-07-14 14:56:33 EDT
1. I wrote 100% of the code without incorporating content from elsewhere or
relying on the intellectual property of others,

2. I have the right to contribute the code to Eclipse, and

3. I have included the EPL license header in all source files.
Comment 4 Matthew Fotzler CLA 2010-07-16 11:13:11 EDT
There is at least one problem with this patch... I imagine we will likely find more as we complete the Move Module Entity refactoring.  So I will wait until we finish that and hopefully just update this patch once.
Comment 5 Jeffrey Overbey CLA 2010-09-21 11:53:43 EDT
Created attachment 179327 [details]
Revised patch - renamed, merged with other changes

There were several conflicts trying to commit this to CVS.  I think I resolved them, but the unit tests are not passing, so I did not commit the refactoring itself or the
test suite. Matt, could you please replace your sources from HEAD (i.e., get
rid of your local changes), then apply the REVISED patch (attached), and see
why the tests are failing?  When it is fixed, please attach a revised revised
patch.  Thanks.
Comment 6 Jeffrey Overbey CLA 2010-09-24 15:12:52 EDT
Change of plans -- we will treat this as part of Move Module Entities (Bug 321790) and send it through IP review as part of that patch/refactoring.

*** This bug has been marked as a duplicate of bug 321790 ***