Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319809 - [pmi] Email notification should indicate which PMC member approved the committer vote
Summary: [pmi] Email notification should indicate which PMC member approved the commit...
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Project Management & Portal (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eric Poirier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 440818
  Show dependency tree
 
Reported: 2010-07-14 02:19 EDT by Dani Megert CLA
Modified: 2018-04-26 14:22 EDT (History)
2 users (show)

See Also:

Attachments
Screenshot (7.63 KB, image/png)
2010-07-14 02:21 EDT, Dani Megert CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-07-14 02:19:23 EDT 
I just approved a committer voting as PMC member of the Eclipse top-level project. There are two issues with that:

1. the mail to the list does not show which PMC member approved it
2. the portal also doesn't show this information (see attached 'screenshot')

The mail should say something like
[platform-releng-dev] Committer vote for Paul Webster has been approved by the 
PMC (Daniel Megert)
    ***************
Comment 1 Dani Megert CLA 2010-07-14 02:21:18 EDT 
Created attachment 174260 [details]
Screenshot
Comment 2 Dani Megert CLA 2010-07-26 03:08:54 EDT 
>1. the mail to the list does not show which PMC member approved it
Actually, this is only partially true: the notification to [eclipse-pmc] is sent under the name of the PMC member who approved it, e.g.
john_arthorne@ca.ibm.com (portal on behalf of John Arthorne)

but the notification to the component list (e.g. [platform-core-dev]) looks like this:
portal-noreply@eclipse.org (portal on behalf of portal-noreply)
Comment 3 Eclipse Genie CLA 2014-10-23 02:56:34 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Dani Megert CLA 2014-10-23 04:19:01 EDT 
This bug is still present.
Comment 5 Eclipse Genie CLA 2016-10-13 00:45:08 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Dani Megert CLA 2016-10-13 08:16:58 EDT 
This is still broken, e.g.
https://dev.eclipse.org/mhonarc/lists/platform-releng-dev/msg25262.html

From: portal-noreply@xxxxxxxxxxx (portal on behalf of portal-noreply)
Comment 7 Wayne Beaton CLA 2016-10-13 16:16:43 EDT 
The webdev team is almost ready with a new implementation based in the PMI.
Comment 8 Christopher Guindon CLA 2016-11-07 14:00:15 EST 
(In reply to Wayne Beaton from comment #7)
> The webdev team is almost ready with a new implementation based in the PMI.

I am assigning this to Eric to make sure this is included in the update of the committer paperwork.
Comment 9 Eric Poirier CLA 2016-11-09 16:50:16 EST 
Once this patch for the PMI is merged:

https://foundation.eclipse.org/r/#/c/598/

I will be able to the changes asked in this bug.
Comment 10 Eric Poirier CLA 2018-04-26 14:22:26 EDT 
This has been merged to production.

Please reopen if there's an issue with this change.

Thanks.