Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319796 - SWTGraphics#clipPath(Path) need to ensure the path is closed
Summary: SWTGraphics#clipPath(Path) need to ensure the path is closed
Status: RESOLVED FIXED
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy Draw2d (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6.1 (Helios SR1)   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-13 18:48 EDT by Alex Boyko CLA
Modified: 2010-07-14 12:16 EDT (History)
2 users (show)

See Also:

Attachments
patch (3.72 KB, patch)
2010-07-13 18:48 EDT, Alex Boyko CLA 		no flags Details | Diff
patch (3.71 KB, patch)
2010-07-13 20:26 EDT, Alex Boyko CLA 		aboyko: review?
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Boyko CLA 2010-07-13 18:48:19 EDT 
Created attachment 174242 [details]
patch

#clipPath(Path) requires the Path to be explicitly closed whyle #setClip(Path) doesn't. The new clipPath(Path) should accept the same input as setClip(Path)

Tested out, seems to be working.

Lidija, can you please review?
Comment 1 Alex Boyko CLA 2010-07-13 20:26:12 EDT 
Created attachment 174243 [details]
patch

The problem is not the Path is not closed but rather that there is a typo in loadPath(Region, float[], int[]) utility method.
Lidija, can you please review this patch?
Comment 2 Lidija Grahek CLA 2010-07-14 11:57:50 EDT 
Looks good Alex.
Comment 3 Alex Boyko CLA 2010-07-14 12:16:14 EDT 
Thanks! I delivered to 3.6 maintenance and HEAD