Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319748 - Missing/unnecessary $NON-NLS$ tags
Summary: Missing/unnecessary $NON-NLS$ tags
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-other (show other bugs)
Version: 7.0   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 8.0   Edit
Assignee: Andrew Gvozdev CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 319850
  Show dependency tree
 
Reported: 2010-07-13 11:50 EDT by Petri Tuononen CLA
Modified: 2010-07-15 11:38 EDT (History)
0 users

See Also:

Attachments
Adds $NON-NLS$ tags and removes unnecessary tags. (92.91 KB, patch)
2010-07-13 11:52 EDT, Petri Tuononen CLA 		angvoz.dev: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petri Tuononen CLA 2010-07-13 11:50:48 EDT 
Build Identifier: 20100617-1415

There's quite a few warnings about non-externalized String literals which need $NON-NLS$ tags and the tag is also unnecessary in certain lines.

Reproducible: Always
Comment 1 Petri Tuononen CLA 2010-07-13 11:52:59 EDT 
Created attachment 174169 [details]
Adds $NON-NLS$ tags and removes unnecessary tags.
Comment 2 Petri Tuononen CLA 2010-07-13 11:54:50 EDT 
Forgot to mention that this patch applies to all CDT projects under CDT CVS HEAD.
Comment 3 Andrew Gvozdev CLA 2010-07-15 10:38:36 EDT 
I applied the patch on HEAD (8.0) selectively, only clear cut ones. Some of the string literals may require externalization rather than $NON-NLS$ tags. Thanks for the patch.
Comment 4 CDT Genie CLA 2010-07-15 11:38:37 EDT 
*** cdt cvs genie on behalf of agvozdev ***
bug 319748: Missing/unnecessary -NLS$ tags
patch from Petri Tuononen

[*] SimpleMakefileGenerator.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.gnu.ui/src/org/eclipse/cdt/managedbuilder/gnu/templates/SimpleMakefileGenerator.java?root=Tools_Project&r1=1.5&r2=1.6

[*] CBreakpointManager.java 1.100 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/CBreakpointManager.java?root=Tools_Project&r1=1.99&r2=1.100
[*] CDebugAdapter.java 1.10 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/CDebugAdapter.java?root=Tools_Project&r1=1.9&r2=1.10

[*] CDebugUtils.java 1.32 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/core/CDebugUtils.java?root=Tools_Project&r1=1.31&r2=1.32

[*] CValue.java 1.83 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/model/CValue.java?root=Tools_Project&r1=1.82&r2=1.83
[*] CStackFrame.java 1.67 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/model/CStackFrame.java?root=Tools_Project&r1=1.66&r2=1.67
[*] CThread.java 1.102 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/model/CThread.java?root=Tools_Project&r1=1.101&r2=1.102

[*] CBreakpoint.java 1.31 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/breakpoints/CBreakpoint.java?root=Tools_Project&r1=1.30&r2=1.31
[*] CWatchpoint.java 1.16 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/breakpoints/CWatchpoint.java?root=Tools_Project&r1=1.15&r2=1.16

[*] BreakpointActionManager.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/core/breakpointactions/BreakpointActionManager.java?root=Tools_Project&r1=1.4&r2=1.5

[*] ExecutablesViewer.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/views/executables/ExecutablesViewer.java?root=Tools_Project&r1=1.7&r2=1.8
[*] ExecutablesViewerComparator.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/views/executables/ExecutablesViewerComparator.java?root=Tools_Project&r1=1.2&r2=1.3

[*] AddEventBreakpointActionDelegate.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/AddEventBreakpointActionDelegate.java?root=Tools_Project&r1=1.1&r2=1.2
[*] CanFormatObjectTester.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/CanFormatObjectTester.java?root=Tools_Project&r1=1.1&r2=1.2
[*] AddWatchpointDialog.java 1.14 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/AddWatchpointDialog.java?root=Tools_Project&r1=1.13&r2=1.14
[*] AddGlobalsActionDelegate.java 1.22 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/AddGlobalsActionDelegate.java?root=Tools_Project&r1=1.21&r2=1.22

[*] AddEventBreakpointDialog.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/dialogs/AddEventBreakpointDialog.java?root=Tools_Project&r1=1.3&r2=1.4

[*] ImportExecutablePageOne.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui/importexecutable/ImportExecutablePageOne.java?root=Tools_Project&r1=1.8&r2=1.9
[*] ImportExecutablePageTwo.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui/importexecutable/ImportExecutablePageTwo.java?root=Tools_Project&r1=1.7&r2=1.8

[*] DefaultCBreakpointUIContribution.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui/breakpoints/DefaultCBreakpointUIContribution.java?root=Tools_Project&r1=1.2&r2=1.3
[*] CBreakpointUIContributionFactory.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui/breakpoints/CBreakpointUIContributionFactory.java?root=Tools_Project&r1=1.2&r2=1.3

[*] DisassemblyEditorInput.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/editor/DisassemblyEditorInput.java?root=Tools_Project&r1=1.1&r2=1.2

[*] ExternalToolActionComposite.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui/breakpointactions/ExternalToolActionComposite.java?root=Tools_Project&r1=1.1&r2=1.2

[*] CBreakpointPropertyPage.java 1.15 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/propertypages/CBreakpointPropertyPage.java?root=Tools_Project&r1=1.14&r2=1.15

[*] CSourceNotFoundEditor.java 1.20 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/sourcelookup/CSourceNotFoundEditor.java?root=Tools_Project&r1=1.19&r2=1.20

[*] ModuleDetailPane.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/views/modules/ModuleDetailPane.java?root=Tools_Project&r1=1.3&r2=1.4

[*] ErrorStatusHandler.java 1.10 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/ErrorStatusHandler.java?root=Tools_Project&r1=1.9&r2=1.10

[*] MiConsoleMessages.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.ui/src/org/eclipse/cdt/debug/mi/ui/console/actions/MiConsoleMessages.java?root=Tools_Project&r1=1.1&r2=1.2
[*] IMiConsoleImagesConst.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.ui/src/org/eclipse/cdt/debug/mi/ui/console/actions/IMiConsoleImagesConst.java?root=Tools_Project&r1=1.1&r2=1.2

[*] StandardGDBDebuggerPage.java 1.16 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.ui/src/org/eclipse/cdt/debug/mi/internal/ui/StandardGDBDebuggerPage.java?root=Tools_Project&r1=1.15&r2=1.16

[*] UpdateManagedProject12.java 1.22 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/projectconverter/UpdateManagedProject12.java?root=Tools_Project&r1=1.21&r2=1.22
[*] UpdateManagedProject20.java 1.18 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/projectconverter/UpdateManagedProject20.java?root=Tools_Project&r1=1.17&r2=1.18

[*] FileInfoModification.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/tcmodification/FileInfoModification.java?root=Tools_Project&r1=1.7&r2=1.8

[*] ProjectType.java 1.23 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/ProjectType.java?root=Tools_Project&r1=1.22&r2=1.23
[*] HoldsOptions.java 1.20 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/HoldsOptions.java?root=Tools_Project&r1=1.19&r2=1.20
[*] MultiFileInfo.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/MultiFileInfo.java?root=Tools_Project&r1=1.1&r2=1.2
[*] ManagedCommandLineGenerator.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/ManagedCommandLineGenerator.java?root=Tools_Project&r1=1.10&r2=1.11

[*] BuildLanguageData.java 1.14 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/dataprovider/BuildLanguageData.java?root=Tools_Project&r1=1.13&r2=1.14

[*] GnuMakefileGenerator.java 1.93 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/makegen/gnu/GnuMakefileGenerator.java?root=Tools_Project&r1=1.92&r2=1.93

[*] CygwinMIEnvironmentCD.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/mi/org/eclipse/cdt/debug/mi/core/command/factories/win32/CygwinMIEnvironmentCD.java?root=Tools_Project&r1=1.5&r2=1.6
[*] CygwinMIEnvironmentDirectory.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/mi/org/eclipse/cdt/debug/mi/core/command/factories/win32/CygwinMIEnvironmentDirectory.java?root=Tools_Project&r1=1.5&r2=1.6

[*] CLIInfoLineInfo.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/mi/org/eclipse/cdt/debug/mi/core/output/CLIInfoLineInfo.java?root=Tools_Project&r1=1.4&r2=1.5

[*] Watchpoint.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/cdi/org/eclipse/cdt/debug/mi/core/cdi/model/Watchpoint.java?root=Tools_Project&r1=1.10&r2=1.11
[*] Value.java 1.15 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/cdi/org/eclipse/cdt/debug/mi/core/cdi/model/Value.java?root=Tools_Project&r1=1.14&r2=1.15

[*] MIGDBSetNewConsole.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/mi/org/eclipse/cdt/debug/mi/core/command/MIGDBSetNewConsole.java?root=Tools_Project&r1=1.3&r2=1.4

[*] CLIProcessor.java 1.14 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/mi/org/eclipse/cdt/debug/mi/core/CLIProcessor.java?root=Tools_Project&r1=1.13&r2=1.14

[*] GDBCDIDebugger.java 1.22 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/src/org/eclipse/cdt/debug/mi/core/GDBCDIDebugger.java?root=Tools_Project&r1=1.21&r2=1.22