Comment 1 Darin Wright 2010-07-13 11:44:29 EDT

The following bundles are affected:

/org.eclipse.pde.api.tools.ui
/org.eclipse.pde.ds.ui
/org.eclipse.pde.runtime
/org.eclipse.pde.ui
/org.eclipse.pde.ui.templates
/org.eclipse.pde.ui.tests

Comment 2 Darin Wright 2010-07-14 12:35:13 EDT

After consulting with Tom, it appears there is no reason that PDE needs to follow JDT to a 1.5 BREE. We should only change the BREE for bundles that actually require 1.5 features (like consuming 1.5 APIs, or using 1.5 class library features).

Removing target milestone.

Comment 3 Curtis Windatt 2012-09-25 13:34:49 EDT

For 4.3 we would like to move up the following bundles

org.eclipse.pde.core
org.eclipse.pde.ui

The other bundles in PDE could be moved up at a later date, but currently there is no advantage to doing so.

Comment 4 Curtis Windatt 2012-09-26 17:27:06 EDT

Work is being done in a topic branch:

http://git.eclipse.org/c/pde/eclipse.pde.ui.git/?h=cwindatt%2FBug319744_Move_to_1_5

Comment 5 Curtis Windatt 2012-10-02 12:08:29 EDT

Update has been pushed to master

http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=f7dbd7542f50f539fe218121874c3aab0d24100f

There are multiple commits.  I did not squash merge them as each commit touches a lot of files.  We will test the N build starting tomorrow.

Comment 6 Dani Megert 2012-10-05 07:00:06 EDT

(In reply to comment #5)
> Update has been pushed to master
> 
> http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/
> ?id=f7dbd7542f50f539fe218121874c3aab0d24100f
> 
> There are multiple commits.  I did not squash merge them as each commit
> touches a lot of files.  We will test the N build starting tomorrow.

The change in is not good. I now get CCEs (see below).
Fixed with http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=298ad42c34717c305f5d5cf9bca5cf38075632b3


I saw that you converted the fields from Vector to ArrayList. Two questions:
1) Did you verify that it is OK to go from a synchronized to a non-synchronized 
   collection?
1) Why did you keep the Vector at other places?



!ENTRY org.eclipse.pde.core 4 0 2012-10-05 11:36:59.420
!MESSAGE java.util.ArrayList cannot be cast to java.util.Vector
!STACK 0
java.lang.ClassCastException: java.util.ArrayList cannot be cast to java.util.Vector
	at org.eclipse.pde.internal.core.schema.Schema.getResolvedElements(Schema.java:255)
	at org.eclipse.pde.internal.core.schema.Schema.resolveElementReference(Schema.java:829)
	at org.eclipse.pde.internal.core.schema.Schema.resolveReference(Schema.java:843)
	at org.eclipse.pde.internal.core.schema.Schema.resolveReferences(Schema.java:850)
	at org.eclipse.pde.internal.core.schema.Schema.traverseDocumentTree(Schema.java:925)
	at org.eclipse.pde.internal.core.schema.Schema.load(Schema.java:371)
	at org.eclipse.pde.internal.core.schema.Schema.load(Schema.java:348)
	at org.eclipse.pde.internal.core.schema.SchemaDescriptor.getSchema(SchemaDescriptor.java:72)
	at org.eclipse.pde.internal.core.schema.SchemaRegistry.getSchema(SchemaRegistry.java:50)
	at org.eclipse.pde.internal.core.builders.ExtensionsErrorReporter.validateExtension(ExtensionsErrorReporter.java:108)
	at org.eclipse.pde.internal.core.builders.ExtensionsErrorReporter.validateContent(ExtensionsErrorReporter.java:75)
	at org.eclipse.pde.internal.core.builders.ManifestConsistencyChecker.validateFiles(ManifestConsistencyChecker.java:296)
	at org.eclipse.pde.internal.core.builders.ManifestConsistencyChecker.validateProject(ManifestConsistencyChecker.java:223)
	at org.eclipse.pde.internal.core.builders.ManifestConsistencyChecker.build(ManifestConsistencyChecker.java:157)
	at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:728)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:199)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:239)
	at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:292)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:295)
	at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:351)
	at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:374)
	at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:143)
	at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:241)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)

Comment 7 Curtis Windatt 2012-10-05 12:31:32 EDT

(In reply to comment #6)

> I saw that you converted the fields from Vector to ArrayList. Two questions:
> 1) Did you verify that it is OK to go from a synchronized to a
> non-synchronized 
>    collection?
> 1) Why did you keep the Vector at other places?

I saw the CCEs and had the same fix locally, but didn't push for last night's nightly.  Looking at the class, there isn't a good reason to switch to ArrayLists, so it must have been an oversight on my part.  I pushed a change to use Vectors instead.  I also went through all the BREE commits and Schema.java is the only class I changed Vectors to lists. 

http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=eb1fa2242e08dbcba5cf0087a238b7fb4f40f318

Comment 8 Curtis Windatt 2012-10-10 10:54:14 EDT

Marking as FIXED.  With the schema fix in I haven't had any problems with the N and now I builds.

Comment 9 Curtis Windatt 2012-10-30 13:10:39 EDT

No more issues showed up during M3.  Verified with I20121030-0800.

Comment 10 Eclipse Genie 2015-11-30 21:56:39 EST

New Gerrit change created: https://git.eclipse.org/r/61611

Comment 11 Eclipse Genie 2015-12-01 03:33:32 EST

Gerrit change https://git.eclipse.org/r/61611 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=1837573ce7fdb32310064e06230cd995173dc2f6