Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319639 - Unwanted newlines before display name value
Summary: Unwanted newlines before display name value
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Carl Anderson CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks: 319735
  Show dependency tree
 
Reported: 2010-07-12 17:33 EDT by Carl Anderson CLA
Modified: 2010-07-20 11:22 EDT (History)
1 user (show)

See Also:
david_williams: pmc_approved+
ccc: pmc_approved? (raghunathan.srinivasan)
ccc: pmc_approved? (naci.dai)
deboer: pmc_approved+
ccc: pmc_approved? (neil.hauge)
ccc: pmc_approved? (kaloyan)
cbridgha: review+

Attachments
Remove the new line after <display-name> (8.56 KB, patch)
2010-07-12 17:34 EDT, Carl Anderson CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Anderson CLA 2010-07-12 17:33:03 EDT 
An adopter product has run into problems where the display name formatting can cause issues with other tools.  As an example, today an EAR 5.0 named Ear50 would be created with:

<display-name>
Ear50</display-name>

Instead, we should have:

<display-name>Ear50</display-name>

Note that this was previously fixed for older J2EE versions- see bug 271837.  This fixes up Java EE 5 and 6 default content.
Comment 1 Carl Anderson CLA 2010-07-12 17:34:29 EDT 
Created attachment 174104 [details]
Remove the new line after <display-name>
Comment 2 Chuck Bridgham CLA 2010-07-13 14:14:21 EDT 
approved
Comment 3 Carl Anderson CLA 2010-07-13 14:33:01 EDT 
This bug causes both ugliness in the deployment descriptor as well as problems with other (non Eclipse) tooling that works with Java EE projects and parses their deployment descriptors.
The workaround is to manually fix up each deployment descriptor. 
The JUnit bucket has been run against this fix, and it has been tested by hand.
Simply put, for EAR, App Client, and EJB projects, the /n after the <display-name> in the deployment descriptor string has been removed.  Other project types are not affected because they insert the display name in a different method.  Chuck Bridgham has reviewed this fix.
This is an extremely low risk fix.
Comment 4 Carl Anderson CLA 2010-07-14 09:38:27 EDT 
Committed to HEAD for WTP 3.2.1 and WTP 3.3