Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319631 - [UI] Console view's Toolbar is being disposed on a perspective close
Summary: [UI] Console view's Toolbar is being disposed on a perspective close
Status: RESOLVED WORKSFORME
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-12 16:23 EDT by Eric Moffatt CLA
Modified: 2019-06-05 07:44 EDT (History)
0 users

See Also:


Attachments
Patch to safe up the switching code (1.38 KB, patch)
2010-07-12 16:25 EDT, Eric Moffatt CLA
no flags Details | Diff
Patch to send the ToolBar to limbo when we put the part there (1.78 KB, patch)
2010-07-13 15:13 EDT, Eric Moffatt CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2010-07-12 16:23:33 EDT
This is a recent happening...now if I close a perspective I get an NPE and the client area is blank.

It turns out that this was choking on the LSR code for clearing out the current TB in a stack that is being shown (i.e. the NPE happens because I closed the Debug perspective and the Java perspective also has a visible 'Outline' view.

This is most likely the result of changing the code last week to ensure that view tb's 'never' get disposed.
Comment 1 Eric Moffatt CLA 2010-07-12 16:25:38 EDT
Created attachment 174095 [details]
Patch to safe up the switching code
Comment 2 Eric Moffatt CLA 2010-07-12 16:28:34 EDT
Committed in >20100712. Applied the patch.

I still have to track down why/how the TB is getting disposed in the first place...current theory is that when I close the perspective its Composite gets disposed (which will cause any visible ToolBar in the TopRight of a CTF to be disposed. We have code that is supposed to 'unhook' shared parts that should be taking care of this...
Comment 3 Eric Moffatt CLA 2010-07-13 15:13:36 EDT
Created attachment 174216 [details]
Patch to send the ToolBar to limbo when we put the part there
Comment 4 Eclipse Genie CLA 2018-12-25 19:25:02 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 5 Lars Vogel CLA 2019-06-05 07:44:33 EDT
This is a mass change to close all e4 bugs marked with "stalebug" whiteboard.

If this bug is still valid, please reopen and remove the "stalebug" keyword.