Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319585 - Java EE Preferences should use the product preference value while determining default value for DD generation when creating connector project
Summary: Java EE Preferences should use the product preference value while determining...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Hari Shankar CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-12 10:50 EDT by Hari Shankar CLA
Modified: 2010-07-20 11:22 EDT (History)
3 users (show)

See Also:
david_williams: pmc_approved+
hshanka: pmc_approved? (raghunathan.srinivasan)
hshanka: pmc_approved? (naci.dai)
deboer: pmc_approved+
hshanka: pmc_approved? (neil.hauge)
hshanka: pmc_approved? (kaloyan)
cbridgha: review+

Attachments
patch (2.83 KB, patch)
2010-07-12 12:44 EDT, Hari Shankar CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hari Shankar CLA 2010-07-12 10:50:33 EDT 
Build Identifier: 321

Java EE Preferences should use the product preference value while determining default value for  DD generation when creating connector project. 

This will help adopter products override the value as appropriate.

Reproducible: Always
Comment 1 Hari Shankar CLA 2010-07-12 12:44:53 EDT 
Created attachment 174067 [details]
patch

This patch acquires the value of the EE6_CONNECTOR_GENERATE_DD variable from the ProductManager, allowing adopter products to override the value.
Comment 2 Chuck Bridgham CLA 2010-07-12 13:38:33 EDT 
Note that behavior did not change, but we were missing a product hook for this preference - approved
Comment 3 Hari Shankar CLA 2010-07-12 13:49:57 EDT 
    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

This issue prevents adopter product from overriding the default value of the Generate DD check box in the connector project creation wizard. This inability to override the default value has the potential to result in customer issues.

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 
Customers will be required to manually check the check box (override the default). However this will be realized too late in the application development lifecycle, resulting in costly delays.

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
This fix does not change the behavior in WTP. This has been verified by bringing up wtp and invoking the connector project wizard.

    * Give a brief technical overview. Who has reviewed this fix? 
This fix has been reviewed by Chuck Bridgham.
    * What is the risk associated with this fix? 
No known risks.
Comment 4 Jason Sholl CLA 2010-07-13 15:11:00 EDT 
code checked into HEAD for WTP 3.2.1